Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compilation fails if Default*Pairs unimplemented in service #821

Merged
merged 5 commits into from
Sep 24, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Sep 22, 2021

fix #760

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 22, 2021

Maybe default_storage_pairs and storage_features should be required?

How about always add default_storage_pairs and storage_features for services?

@JinnyYi
Copy link
Contributor Author

JinnyYi commented Sep 22, 2021

Maybe default_storage_pairs and storage_features should be required?

How about always add default_storage_pairs and storage_features for services?

Does it mean default_storage_pairs should be added in namespace.storage.new for all services? Or should we generate DefaultStoragePairs in pairStorageNew struct no matter there's defalt pair or not?

For storage_features, no additional logic is currently required to handle it.

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 22, 2021

Does it mean default_storage_pairs should be added in namespace.storage.new for all services?

Yes, I think this way could be better.

@JinnyYi
Copy link
Contributor Author

JinnyYi commented Sep 22, 2021

Does it mean default_storage_pairs should be added in namespace.storage.new for all services?

Yes, I think this way could be better.

Then maybe we don't need to modify go-storage for default_storage_pairs.

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 23, 2021

Then maybe we don't need to modify go-storage for default_storage_pairs.

How about adding them by default? And finally, we can remove default_storage_pairs in services.toml as they will be auto-added.

@Xuanwo Xuanwo enabled auto-merge (squash) September 24, 2021 09:17
@Xuanwo Xuanwo merged commit 4bda6fb into master Sep 24, 2021
@Xuanwo Xuanwo deleted the issue-760 branch September 24, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails if Default*Pairs unimplemented in service
2 participants