fix: Compilation fails if Default*Pairs unimplemented in service

cmd/definitions/gen_service.go

@@ -270,16 +270,18 @@ GetStorageSystemMetadata will get StorageSystemMetadata from Storage.
 				for _, feature := range ns.ParsedFeatures() {
 					featureNameP := templateutils.ToPascal(feature.Name)
 
-					gg.If(gg.S("result.hasEnable%s", featureNameP)).
+					group.
+						NewIf(gg.S("result.hasEnable%s", featureNameP)).
 						AddBody(
 							gg.S("result.Has%sFeatures = true", nsNameP),
 							gg.S("result.%sFeatures.%s = true", nsNameP, featureNameP),
 						)
 				}
 				return group
 			}),
+			gg.LineComment("Default pairs"),
 			gg.Embed(func() gg.Node {
-				// Generate default pari handle logic here.
+				// Generate default pair handle logic here.
 				group := gg.NewGroup()
 
 				for _, dp := range ns.ParsedDefaultable() {

cmd/definitions/type.go

@@ -236,6 +236,7 @@ func (d *Data) LoadService(filePath string) {
 	d.Service = &Service{
 		d: d,
 	}
+	d.Service.Pairs = make(map[string]*Pair)
 	err = parseTOML(bs, d.Service)
 	if err != nil {
 		log.Fatalf("parse service: %v", err)
@@ -307,14 +308,36 @@ func (d *Data) LoadService(filePath string) {
 		ns.New.srv = srv
 		ns.New.ns = ns
 		ns.New.Implemented = true
-		for _, v := range d.PairsMap {
-			if v.Defaultable {
-				ns.New.Optional = append(ns.New.Optional, "default_"+v.Name)
+		for _, v := range ns.ParsedDefaultable() {
+			ns.New.Optional = append(ns.New.Optional, "default_"+v.Pair.Name)
+		}
+		// add default_*_pairs and *_features
+		hasDefaultNsPairs := false
+		hasNsFeatures := false
+		defaultNsPairsName := fmt.Sprintf("default_%s_pairs", ns.Name)
+		nsFeaturesName := fmt.Sprintf("%s_features", ns.Name)
+		for _, v := range ns.New.Optional {
+			if v == defaultNsPairsName {
+				log.Warnf("Please remove %s pair as it will be automatically generated.", defaultNsPairsName)
+				hasDefaultNsPairs = true
+			}
+			if v == nsFeaturesName {
+				log.Warnf("Please remove %s pair as it will be automatically generated.", nsFeaturesName)
+				hasNsFeatures = true
+			}
+		}
+		if !hasDefaultNsPairs {
+			ns.New.Optional = append(ns.New.Optional, defaultNsPairsName)
+			srv.Pairs[defaultNsPairsName] = &Pair{
+				Name: defaultNsPairsName,
+				Type: templateutils.ToPascal(defaultNsPairsName),
 			}
 		}
-		for _, v := range srv.Pairs {
-			if v.Defaultable {
-				ns.New.Optional = append(ns.New.Optional, "default_"+v.Name)
+		if !hasNsFeatures {
+			ns.New.Optional = append(ns.New.Optional, nsFeaturesName)
+			srv.Pairs[nsFeaturesName] = &Pair{
+				Name: nsFeaturesName,
+				Type: templateutils.ToPascal(nsFeaturesName),
 			}
 		}