Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download_weights.py #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add download_weights.py #46

wants to merge 1 commit into from

Conversation

jaagut
Copy link
Member

@jaagut jaagut commented May 31, 2022

Proposed changes

  • Add python script for downloading pretrained weights
  • Add command yoeo-download-weights for simplification
  • Update Readme doc
  • Remove old bash script

Related issues

Necessary checks

  • Update poetry package version semantically
  • Write documentation
  • [ ] Create issues for future work
  • Test on your machine

@jaagut jaagut force-pushed the refactor/download_weights branch from 22bd967 to 77ec2bc Compare May 31, 2022 14:58
@jaagut jaagut requested review from Flova and phinik May 31, 2022 14:59
@@ -34,3 +34,4 @@ build-backend = "poetry.core.masonry.api"
yoeo-detect = "yoeo.detect:run"
yoeo-train = "yoeo.train:run"
yoeo-test = "yoeo.test:run"
yoeo-download-weights = "scripts.download_weights:run"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really work? Script seems like a non install directory, as it is not in the package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TDB lets test this with a clean install

@jgueldenstein
Copy link
Member

What is the status on this?

@Flova
Copy link
Member

Flova commented Oct 10, 2024

It has been stale for a while, but the bash script should work. It just has no Windows support.

@jaagut jaagut self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

3 participants