Fix parameter write response validation #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter writes were incorrectly treating echoed values as error codes, causing all successful parameter sets to fail with 'Error setting the parameter: code X' where X was the actual value being set.
Root cause: The firmware echoes back the successfully written parameter value, but the Rust implementation was checking byte 2 for an error code (expecting 0 for success).
Fix: Compare the echoed bytes with the expected parameter value bytes to verify the parameter was set correctly.
Tested: Resolves parameter setting failures in (upcoming) example where stabilizer.estimator could not be set to value 2. Can be tested by modifying test_params.rs