Skip to content

Fix parameter write response validation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

Fix parameter write response validation #9

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b21f26
Fix parameter write response validation
gemenerik Sep 12, 2025
d98f29e
Improve parameter error messages
gemenerik Sep 12, 2025
e69a9aa
Add bounds checks to prevent panics in param write response parsing
gemenerik Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/subsystems/param.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,19 @@ impl Param {
.wait_packet(PARAM_PORT, _WRITE_CHANNEL, &param_id.to_le_bytes())
.await?;

if answer.get_data()[2] == 0 {
// Verify the echoed value matches what we tried to set by comparing bytes
let expected_bytes: Vec<u8> = value.into();
let echoed_bytes = &answer.get_data()[2..];
if echoed_bytes == expected_bytes.as_slice() {
// Success: firmware echoed back the value we set
// The param is tested as being in the TOC so this unwrap cannot fail
*self.values.lock().await.get_mut(param).unwrap() = value;
self.notify_watchers(param, value).await;
Ok(())
} else {
Err(Error::ParamError(format!(
"Error setting the parameter: code {}",
answer.get_data()[2]
"Parameter set failed: expected bytes {:?}, got echoed bytes {:?}",
expected_bytes, echoed_bytes
)))
}
}
Expand Down