This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
[BitMex] Restore the Bitmex Execution reports code which was cut out of #191. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-info#191. This is has some issues with the latest codeset (in particular, it doesn't compile against XChange 4.3.11). It needs the attention of someone who actually uses BitMex.
|
Maintainers needed #234 |
Closed
Flemingjp
changed the title
This was referenced Jan 27, 2019
Merged
badgerwithagun
added
bitmex_delayed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191 originally contained Bitmex execution report support. It had heavy overlap with some other urgent PRs, so maintaining a "roll up" of these PRs (which I did in #191) was the only practical way of managing the conflicts during the months when PRs weren't getting applied.
Now, however, things are moving and we are slowly clearing the backlog of urgent PRs.
This Bitmex functionality was mixed in with various other useful performance tweaks and bug fixes which we wanted to get merged urgently. However, we have been short of Bitmex testers/reviewers so this functionality was extracted from that PR with the intention of reapplying it later:
I hope I have correctly credited the original author in this squashed commit.
Note that this doesn't compile. If someone who uses Bitmex could pick this up and get it compiling, that'd be great.