Skip to content

Ensure all struct fields are public#82

Merged
Hinton merged 1 commit into
bitwarden:mainfrom
1Password:progdrasil/fix-private-fields
Jul 18, 2025
Merged

Ensure all struct fields are public#82
Hinton merged 1 commit into
bitwarden:mainfrom
1Password:progdrasil/fix-private-fields

Conversation

@Progdrasil

Copy link
Copy Markdown
Contributor

📔 Objective

While working with the library we noticed a few fields were private. This PR ensures that all struct fields for the data model are public.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton merged commit 9c59214 into bitwarden:main Jul 18, 2025
5 of 6 checks passed
@Progdrasil Progdrasil deleted the progdrasil/fix-private-fields branch July 18, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants