Skip to content

Ensure all struct fields are public #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hinton merged 1 commit into from
Jul 18, 2025
+6 −4
Merged

Ensure all struct fields are public #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions credential-exchange-format/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

- **BREAKING**: Changed all enums to be `#[non_exhaustive]` which allows additive changes to be
non-breaking in the future. (#80)
- **BREAKING**: Changed fields in `Fido2HmacCredentials` and `GeneratedPasswordCredential` to be
public. (#82)
2 changes: 1 addition & 1 deletion credential-exchange-format/src/login.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ pub struct BasicAuthCredential<E = ()> {
#[serde(rename_all = "camelCase")]
pub struct GeneratedPasswordCredential {
/// The machine-generated password.
password: String,
pub password: String,
}

/// An [SshKeyCredential] represents an SSH (Secure Shell) key pair.
Expand Down
6 changes: 3 additions & 3 deletions credential-exchange-format/src/passkey.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,11 @@ pub struct Fido2Extensions {
#[derive(Clone, Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Fido2HmacCredentials {
algorithm: Fido2HmacCredentialAlgorithm,
pub algorithm: Fido2HmacCredentialAlgorithm,
#[serde(rename = "credWithUV")]
cred_with_uv: B64Url,
pub cred_with_uv: B64Url,
#[serde(rename = "credWithoutUV")]
cred_without_uv: B64Url,
pub cred_without_uv: B64Url,
}

#[derive(Clone, Debug, Serialize, Deserialize)]
Expand Down
Loading