Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15377: Rolled back review prompt legacy api #1218

Merged
merged 7 commits into from
Jan 8, 2025

Merge branch 'main' of github.com:livefront/bitwarden-ios into PM-153โ€ฆ

1a3cf40
Select commit
Loading
Failed to load commit list.
Merged

PM-15377: Rolled back review prompt legacy api #1218

Merge branch 'main' of github.com:livefront/bitwarden-ios into PM-153โ€ฆ
1a3cf40
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2025 in 0s

89.61% (-0.03%) compared to b409a15

View this Pull Request on Codecov

89.61% (-0.03%) compared to b409a15

Details

Codecov Report

Attention: Patch coverage is 53.06122% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.61%. Comparing base (b409a15) to head (1a3cf40).

Files with missing lines Patch % Lines
...lication/Appearance/Modifiers/ReviewModifier.swift 47.50% 21 Missing โš ๏ธ
...hared/UI/Vault/Vault/VaultList/VaultListView.swift 33.33% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   89.63%   89.61%   -0.03%     
==========================================
  Files         721      722       +1     
  Lines       45544    45579      +35     
==========================================
+ Hits        40823    40845      +22     
- Misses       4721     4734      +13     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.