[QA-967] Adding missing IDs for Vault page elements #1252
+96
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifernandezdiaz
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
=======================================
Coverage 89.46% 89.47%
=======================================
Files 732 732
Lines 46128 46142 +14
=======================================
+ Hits 41268 41284 +16
+ Misses 4860 4858 -2 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Jan 10, 2025
There was a problem hiding this comment.
⛏️ Remove all unneeded spaces added in the file.
There was a problem hiding this comment.
It's weird because the extra spaces we saw on Github are not there when checking the file on XCode 👀
There was a problem hiding this comment.
Xcode doesn't remove trailing whitespace by default, but you can change that here:
BitwardenShared/UI/Vault/Views/VaultListItemRow/VaultListItemRowView.swift
Outdated
Show resolved
Hide resolved
fedemkr
reviewed
Jan 14, 2025
Comment on lines
+256
to
+263
| XCTAssertEqual( | ||
| VaultListItem(cipherView: .fixture(type: .sshKey))?.vaultItemAccessibilityId, | ||
| "CipherCell" | ||
| ) | ||
| XCTAssertEqual( | ||
| VaultListItem(cipherView: .fixture(type: .sshKey))?.vaultItemAccessibilityId, | ||
| "CipherCell" | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes