[QA-967] Adding missing IDs for Vault page elements

BitwardenShared/UI/Vault/Vault/VaultList/VaultListItem.swift

@@ -15,10 +15,10 @@ public struct VaultListItem: Equatable, Identifiable, Sendable, VaultItemWithDec
         ///   of the `CipherView` to be displayed when needed (Optional).
         ///
         case cipher(CipherView, Fido2CredentialAutofillView? = nil)
-        
+
         /// The wrapped item is a group of items.
         case group(VaultListGroup, Int)
-        
+
         /// A TOTP Code Item.
         ///
         /// - Parameters
@@ -29,10 +29,10 @@ public struct VaultListItem: Equatable, Identifiable, Sendable, VaultItemWithDec
     }
 
     // MARK: Properties
-    
+
     /// The identifier for the item.
     public let id: String
-    
+
     /// The type of item being displayed by this item.
     public let itemType: ItemType
 }
@@ -55,7 +55,7 @@ extension VaultListItem {
         guard let id = cipherView.id else { return nil }
         self.init(id: id, itemType: .cipher(cipherView))
     }
-    
+
     /// Initialize a `VaultListItem` from a `CipherView`.
     /// - Parameters:
     ///   - cipherView: The `CipherView` used to initialize the `VaultListItem`.
@@ -78,7 +78,7 @@ extension VaultListItem {
             nil
         }
     }
-    
+
     /// An image asset for this item that can be used in the UI.
     var icon: ImageAsset {
         switch itemType {
@@ -121,7 +121,7 @@ extension VaultListItem {
             Asset.Images.clock24
         }
     }
-    
+
     /// The accessibility ID for the ciphers icon.
     var iconAccessibilityId: String {
         switch itemType {
@@ -142,8 +142,8 @@ extension VaultListItem {
             return ""
         }
     }
-    
-    /// The accessibility ID for each vault item .
+
+    /// The accessibility ID for each vault item.
     var vaultItemAccessibilityId: String {
         switch itemType {
         case let .group(vaultListGroup, _):
@@ -160,7 +160,8 @@ extension VaultListItem {
             return "TOTPCell"
         }
     }
-
+
+
     /// The login view containing the uri's to download the special decorative icon, if applicable.
     var loginView: BitwardenSdk.LoginView? {
         switch itemType {

BitwardenShared/UI/Vault/Vault/VaultList/VaultListItemTests.swift

@@ -235,6 +235,73 @@ class VaultListItemTests: BitwardenTestCase { // swiftlint:disable:this type_bod
         )
     }
 
+    /// `getter:vaultItemAccessibilityId` gets the appropriate id for each vault item.
+    func test_vaultItemAccessibilityId() { // swiftlint:disable:this function_body_length
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .login))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .card))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .identity))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .secureNote))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .sshKey))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(cipherView: .fixture(type: .sshKey))?.vaultItemAccessibilityId,
+            "CipherCell"
+        )
+
+        XCTAssertEqual(
+            VaultListItem.fixtureTOTP(totp: .fixture()).vaultItemAccessibilityId,
+            "TOTPCell"
+        )
+
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.collection(id: "", name: "", organizationId: "1"), 1))
+                .vaultItemAccessibilityId,
+            "CollectionCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.folder(id: "", name: ""), 1)).vaultItemAccessibilityId,
+            "FolderCell"
+        )
+
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.login, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.card, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.identity, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.secureNote, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.sshKey, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+        XCTAssertEqual(
+            VaultListItem(id: "", itemType: .group(.totp, 1)).vaultItemAccessibilityId,
+            "ItemFilterCell"
+        )
+    }
     /// `name` returns the expected value.
     func test_name() {
         XCTAssertEqual(subject.name, "")