Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-58: Add Github Actions workflow for building and testing #13

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

matt-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-58

🚧 Type of change

  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

Adds a GitHub actions workflow for building and testing the app. This workflow will comment back on the PR with any warnings or errors and test coverage.

📋 Code changes

  • .github/workflows/test.yml: A workflow file to build and test the app and report warnings/errors and test coverage.
  • Dangerfile: Configuration file for Danger. Danger is a ruby gem which allows for adding plugins that can comment on a PR. Here we're using danger-slather to report on code coverage and danger-xcode_summary to report on any build warnings or errors.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

1 Warning
⚠️ Total coverage less than 80%

Code coverage

Total coverage: 48.18%

Powered by Slather

Generated by 🚫 Danger

@withinfocus
Copy link
Contributor

Would be good to wait on @bitwarden/dept-devops for a review as well.

Copy link
Contributor

@nathan-livefront nathan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants