Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ssh key fields non-optional #13

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Make ssh key fields non-optional #13

merged 5 commits into from
Oct 30, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Oct 28, 2024

🎟️ Tracking

📔 Objective

SSH key item fields should never be optional and are always present. All of these are set on creation / update.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as draft October 28, 2024 14:32
@quexten quexten marked this pull request as ready for review October 28, 2024 17:55
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.85%. Comparing base (9c30b63) to head (9e7b0c6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/ssh_key.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   62.84%   62.85%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
+ Hits         7974     7975    +1     
+ Misses       4714     4713    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested a review from dani-garcia October 29, 2024 19:12
@quexten quexten merged commit 5905354 into main Oct 30, 2024
38 checks passed
@quexten quexten deleted the km/sshkey-non-optional branch October 30, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants