Proposal: Move languages to live under the relevant crate #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 62.85% 62.87% +0.02%
==========================================
Files 179 179
Lines 12688 12699 +11
==========================================
+ Hits 7975 7985 +10
- Misses 4713 4714 +1 ☔ View full report in Codecov by Sentry. |
Hinton
changed the title
dani-garcia
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Note that if we're changing this, we also need to either:
- Update the IOS app to support the local SDK in this directory: https://github.com/bitwarden/ios/blob/main/Configs/local-sdk.yml
- Symlink the old directory to the new one in the build script to maintain compatibility
crates/bitwarden-uniffi/swift/iOS/App.xcodeproj/project.xcworkspace/contents.xcworkspacedata
Outdated
Show resolved
Hide resolved
|
I already have a PR for local-sdk.yml, which already needed updates due to the repository move. |
dani-garcia
approved these changes
Nov 12, 2024
vgrassia
approved these changes
Nov 12, 2024
tangowithfoxtrot
added a commit
that referenced
this pull request
Nov 29, 2024
## 📔 Objective When following the Contributing Docs to build the Android app, the build script couldn't find my `libbitwarden_uniffi.so` file. It seems the path for this changed in #26. This just updates the build script to use the new path. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Now that we've split the internal from public sdk we can clean up the languages directory by moving the remaining language bindings to live under the relevant crate that produces them.
This should ideally result in less jumping around in the terminal and editors to go between output and code that produces it.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes