[PM-8618] Credential Exchange #32
Conversation
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 64.06% 64.43% +0.37%
==========================================
Files 186 188 +2
Lines 13057 13830 +773
==========================================
+ Hits 8365 8912 +547
- Misses 4692 4918 +226 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Personal reminder. Json currently does not support passkey exports, web clients do.
…ial-exchange # Conflicts: # Cargo.lock
Hinton
force-pushed
the
credential-exchange
branch
from
dfe65e7 to
95c6f87
Compare
|
|
||
| match value.ty { | ||
| ItemType::Login => { | ||
| let basic_auth = grouped.basic_auth.first(); |
There was a problem hiding this comment.
We're only handling the first element in Item, but it looks like this function could handle more than one as returns a Vec, is this missing from the first version?
There was a problem hiding this comment.
Yes it's a known limitation of the current implementation.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8618
📔 Objective
Initial implementation of the Credential Exchange Format. Currently supports the following types:
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes