[PM-13783] Battle harden ProviderType enum expansion #4523
Triggered via pull request
November 11, 2024 21:22
withinfocus
synchronize
#5004
Status
Success
Total duration
8m 43s
Artifacts
–
scan.yml
on: pull_request_target
Check PR run
/
Check
2s
Annotations
10 warnings
Quality scan:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L11
'ProviderInitiateDeleteModel.WebVaultUrl' hides inherited member 'BaseMailModel.WebVaultUrl'. Use the new keyword if hiding was intended.
|
Quality scan:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L14
'ProviderInitiateDeleteModel.SiteName' hides inherited member 'BaseMailModel.SiteName'. Use the new keyword if hiding was intended.
|
Quality scan:
src/Core/Billing/Services/Implementations/PaymentHistoryService.cs#L15
Parameter 'logger' is unread.
|
Quality scan:
src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/UpdateOrganizationUserCommand.cs#L121
Possible null reference argument for parameter 'collections' in 'Task IOrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections)'.
|
Quality scan:
src/Infrastructure.EntityFramework/AdminConsole/Repositories/OrganizationUserRepository.cs#L251
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Quality scan:
test/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/RemoveOrganizationUserCommandTests.cs#L127
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
|
Quality scan:
test/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/RemoveOrganizationUserCommandTests.cs#L211
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
|
Quality scan:
test/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteManagedOrganizationUserAccountCommandTests.cs#L68
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Quality scan:
test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs#L100
Cannot convert null literal to non-nullable reference type.
|
Quality scan:
test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs#L104
Cannot convert null literal to non-nullable reference type.
|