-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated customer metadata to only store one old btCustomerId #4997
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorask-bitwarden
previously approved these changes
Nov 7, 2024
Fixed Issues
|
amorask-bitwarden
previously approved these changes
Nov 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
=======================================
Coverage 42.66% 42.67%
=======================================
Files 1411 1411
Lines 65087 65087
Branches 5959 5959
=======================================
+ Hits 27772 27773 +1
+ Misses 36075 36074 -1
Partials 1240 1240 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
… Customer's metadata
amorask-bitwarden
approved these changes
Nov 19, 2024
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…en#4997) * Updated customer metadata to only store one old btCustomerId * Updated to include case where old key already exists * Updated SubscriberService to also save btCustomerId_old on the Stripe Customer's metadata --------- Co-authored-by: Matt Bishop <[email protected]>
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
…en#4997) * Updated customer metadata to only store one old btCustomerId * Updated to include case where old key already exists * Updated SubscriberService to also save btCustomerId_old on the Stripe Customer's metadata --------- Co-authored-by: Matt Bishop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14610
📔 Objective
Previously, we would store older braintree customers using the Stripe customer metadata field key of
$"btCustomerId_{Utilities.CoreHelpers.ToEpocSeconds(DateTime.UtcNow)}"
. This led to some customers with a lot of metadata records, which would slow down our reporting ChartMogul software. This PR addresses this by limiting the number of older braintree customers retained to 1.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes