Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some languages (with layout improvement) and address binding was implemented #230

Closed
wants to merge 6 commits into from

Conversation

elluisian
Copy link
Contributor

When applied, this commit will improve the already existing Italian translation, since the current one is a bit broken (no offense of course). This is not a literal translation, the previous one is and it sounds awkward for native Italians (hence, the reason I decided to improve it).

Some notes on my translation decisions:

  • I translated 'Start on Boot' as 'Avvia all'accensione' (Start on powering on), technically, I could use "Avvia dopo il boot" (Start after booting) or similar, but I didn't like it;
  • I translated 'Accessibility' as 'Servizio d'accessibilità' (Accessibility service), I think it's better because technically speaking, one enables an app TO USE accessibility services, it's not like the "accessibility" is a property of the app itself, as suggested by the sentence "enable the accessibility for the app".

Of course, future translators may change things, if they think it's for the best

When applied, this commit will improve the already existing Italian translation, since the current one is a bit broken (no offense of course).
This is not a literal translation, the previous one is and it sounds awkward for native Italians (hence, the reason I decided to improve it).

Some notes on my translation decisions:

- I translated 'Start on Boot' as 'Avvia all'accensione' (Start on powering on), technically, I could use "Avvia dopo il boot" (Start after booting) or similar, but I didn't like it;
- I translated 'Accessibility' as 'Servizio d'accessibilità' (Accessibility service), I think it's better because technically speaking, one enables an app TO USE accessibility services, it's not like the "accessibility" is a property of the app itself, as suggested by the sentence "enable the accessibility for the app".

Of course, future translators may change things, if they think it's for the best
@elluisian elluisian marked this pull request as draft August 20, 2024 23:40
When applied, this commit tries to implement the feature requests reported on issue bk138#43 and bk138#227.
Basically, with this commit, it is possible to instruct the server to listen only on a certain address.

To do this, there is a further edittext "Listening Address", which can be configured.
Please note that if an invalid ip/address is set, by default, it is assumed 0.0.0.0 is requested
When applied, this commit will be an improvement over the commit 355fda6, as in this one, I found a proper way to translate some of the lines in which I was not very sure about
When applied, this commit will add the spanish localization to the app.
Since this is my third language, it may be a bit broken
When applied, this commit will add the french localization to the app.
Since this is my fourth language, it may be a bit broken
When applied, this commit should improve the visuals when using languages different from english.
I've made this a separate commit because I'm not sure this is the best possible solution, there are probably better ways
@elluisian elluisian changed the title res: improved already existing Italian translation Added some languages (with layout improvement) and address binding was implemented Aug 21, 2024
@elluisian
Copy link
Contributor Author

I forgot to add on the commit message for 8029a64 that it also solves a bug related to the shared browser links.
Basically, those hyperlinks always pointed to the port 5800, regardless of the one that was chosen in the administration panel, now that's fixed.

@elluisian elluisian marked this pull request as ready for review August 21, 2024 03:09
@bk138
Copy link
Owner

bk138 commented Aug 21, 2024

Thanks! Please make sure you have a separate PR for each change.

@elluisian
Copy link
Contributor Author

@bk138 Hi, no problem, unfortunately I'm still a beginner in relation to contributing, how do I do that?
Do you mean that I have to make a single PR for each commit?
Sorry for bothering you.

@bk138
Copy link
Owner

bk138 commented Aug 21, 2024

@elluisian No problem, I've cherry-picked the relevant translation commits and updated the commit messages with your name and a new wording (the "when apllied, this commit will ..." is for the first commit message line, the "..." being the first line - it just hints at how the wording is supposed to look like ;-) )

For the commit for #43, please make a new PR so we can iterate on this. The idea is to have one PR for each semantic change :-)

@bk138 bk138 closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants