Skip to content

Update tokio to 1.0 (fix #132)#138

Merged
blackbeam merged 11 commits intomasterfrom
tokio3
Jan 10, 2021
Merged

Update tokio to 1.0 (fix #132)#138
blackbeam merged 11 commits intomasterfrom
tokio3

Conversation

@blackbeam
Copy link
Owner

No description provided.

@blackbeam blackbeam changed the title Update tokio to 0.3 Update tokio to 0.3 (fix #132) Dec 1, 2020
@blackbeam blackbeam changed the title Update tokio to 0.3 (fix #132) Update tokio to 1.0 (fix #132) Jan 6, 2021
@udoprog
Copy link
Contributor

udoprog commented Jan 6, 2021

@blackbeam So NamedPipe support in Tokio appears to be the last blocker (ref tokio-rs/tokio#3118).

The PollEvented type is now private, and support for named pipes has been merged into mio already. I have a compiling prototype and would be willing to work on getting it into Tokio unless you're already doing so?

@udoprog
Copy link
Contributor

udoprog commented Jan 6, 2021

Here's my branches if someone wants to give it a shot:
Tokio: https://github.com/udoprog/tokio/tree/named-pipes
mysql_async: https://github.com/udoprog/mysql_async/tree/tokio1

I'll try it later when I can get a working mariadb installation up and running, but can't right now!

@blackbeam
Copy link
Owner Author

Hi, @udoprog.

Looks like we've started this at the same time (see tokio-rs/tokio#3388), however I not yet have a working mysql_async version based on my fork.

Regarding mysql_async update: I think it's reasonable to remove NamedPipes support for now and reintroduce later when it'll be merged into tokio.

@udoprog
Copy link
Contributor

udoprog commented Jan 6, 2021

Hi, @udoprog.

Looks like we've started this at the same time (see tokio-rs/tokio#3388), however I not yet have a working mysql_async version based on my fork.

Regarding mysql_async update: I think it's reasonable to remove NamedPipes support for now and reintroduce later when it'll be merged into tokio.

That is fine by me! I'm just motivated to get a new release of your wonderful library out the door ASAP.

I'd be glad to help in any way I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants