Feature: STM32H523/H533 support - #2131
Conversation
dragonmux
left a comment
There was a problem hiding this comment.
Generally looking good - there are just a handful of fairly small things that we'd appreciate being addressed so this is all good to go for the v2.1 cycle starting.
e7b4b77 to
4d375ca
Compare
|
Okay, retested on STM32H562RG that is 1 MiB capacity, and here's a bugreport. |
|
This is one for @esden to chime in but our feeling here is to have you tidy up, move this to the v2.0 milestone and merge it ASAP for the final release. The splash-back that's possible is super minimal as it's only poking at the STM32H5 support, not something deeper in the debugging core. |
4d375ca to
2000554
Compare
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, please rebase this on main and we'll get it merged. Thank you for the contribution!
2000554 to
19efc5b
Compare
Detailed description
Additionally, I've noticed there's actually two flash capacity SKUs possible for STM32H563 (2MB, 1MB) and STM32H523 (512KB, 256KB) but only 2MB was handled, so I added a known feature/trick of reading out FLASH_SIZE from engineering bytes and calculating bank size / sector count from that. STM32H503 is always 128KB and is unaffected.
mon revextended, likewise.mon uidworks.Data area not handled yet, option bytes not handled.
Tested on https://github.com/WeActStudio/WeActStudio.STM32H523CoreBoard with
blackpill-f411ce. First 32 KiB demo (based on USBX) passes verification.106 KB/secwrite speed,138 KiB/sread speed.Ideally STM32H562RG should be tested before merge, too (as found in https://github.com/WeActStudio/WeActStudio.STM32H5_64Pin_CoreBoard); and "STM32H5xx" now means "STM32H573/H563/H562" -- H573 has crypto and EMAC, H563 has Ethernet MAC, H562 has neither.
Your checklist for this pull request
Closing issues
No request filed yet.