qlean integration #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
commented
Oct 4, 2025
client-cmds/qlean-cmd.sh
Outdated
| --bootnodes $configDir/nodes.yaml | ||
| --node-id $item --node-key /config/$privKeyPath \ | ||
| --listen-addr /ip4/0.0.0.0/udp/$quicPort/quic-v1 \ | ||
| 2>&1 | tee $dataDir/$item.log" |
Collaborator
Author
There was a problem hiding this comment.
I assumed that capturing logs to file helps debugging and should be enabled for all nodes.
Please don't add this to node_binary.
Suggested change
| 2>&1 | tee $dataDir/$item.log" |
Member
There was a problem hiding this comment.
nodes should auto gen logs in data dir for example zeam writes file logs with debug level while console logs are only info level
so its upto the client what they want and hence in a particular client cmd
g11tech
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitfor&jobs, stops jobs on ctrl+c.teeto log files.scriptDir.mkdir -pto suppress existing directory warning.rmwithoutsudo.