Skip to content

qlean integration #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g11tech merged 7 commits into from
Oct 5, 2025
Merged

qlean integration #10

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2736626
rebase qlean cmd to new format
g11tech Oct 4, 2025
bfd75a1
small cleanup
g11tech Oct 4, 2025
3037583
remove log capture
turuslan Oct 5, 2025
b6ed186
fix merge
turuslan Oct 5, 2025
be5a8e6
fix key path
turuslan Oct 5, 2025
b0f123e
--data-dir
turuslan Oct 5, 2025
0d4d022
qlean docker
turuslan Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions client-cmds/qlean-cmd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
#!/bin/bash

#-----------------------qlean setup----------------------
node_binary=
# expects "qlean" submodule or symlink inside "lean-quickstart" root directory
# https://github.com/qdrvm/qlean-mini
node_binary="$scriptDir/qlean/build/src/executable/qlean \
--modules-dir $scriptDir/qlean/build/src/modules \
--genesis $configDir/config.yaml \
--validator-registry-path $configDir/validators.yaml \
--bootnodes $configDir/nodes.yaml
--node-id $item --node-key /config/$privKeyPath \
--listen-addr /ip4/0.0.0.0/udp/$quicPort/quic-v1 \
2>&1 | tee $dataDir/$item.log"
Copy link
Collaborator Author

@turuslan turuslan Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that capturing logs to file helps debugging and should be enabled for all nodes.
Please don't add this to node_binary.

Suggested change
2>&1 | tee $dataDir/$item.log"

Copy link
Member

@g11tech g11tech Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodes should auto gen logs in data dir for example zeam writes file logs with debug level while console logs are only info level

so its upto the client what they want and hence in a particular client cmd


node_docker=

# choose either binary or docker
node_setup="docker"
node_setup="binary"
14 changes: 7 additions & 7 deletions spin-node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

currentDir=$(pwd)
scriptDir=$(dirname $0)
if [ "$scriptDir" == "." ]; then
scriptDir="$currentDir"
fi

# 0. parse env and args
source "$(dirname $0)/parse-env.sh"
Expand All @@ -13,10 +16,7 @@ source "$(dirname $0)/set-up.sh"
# should take config.yaml and validator-config.yaml and generate files
# 1. nodes.yaml 2. validators.yaml 3. .key files for each of nodes

# 2. get the client cmds with args set
source "$scriptDir/$NETWORK_DIR/client_env.sh"

# 3. collect the nodes that the user has asked us to spin and perform setup
# 2. collect the nodes that the user has asked us to spin and perform setup
if [ "$validatorConfig" == "genesis_bootnode" ] || [ -z "$validatorConfig" ]; then
validator_config_file="$configDir/validator-config.yaml"
else
Expand Down Expand Up @@ -46,13 +46,13 @@ then
exit;
fi;

# 4. run clients
mkdir $dataDir
# 3. run clients
mkdir -p $dataDir
popupTerminalCmd="gnome-terminal --disable-factory --"
for item in "${spin_nodes[@]}"; do
# create and/or cleanup datadirs
itemDataDir="$dataDir/$item"
mkdir $itemDataDir
mkdir -p $itemDataDir
cmd="sudo rm -rf $itemDataDir/*"
echo $cmd
eval $cmd
Expand Down