Drop # type: ignore comments for @hookimpl
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
drop_hookimpl_type_ignore_comments
branch
from
b399318
to
7a851e8
Compare
sarahmonod
previously approved these changes
Sep 25, 2023
godlygeek
force-pushed
the
drop_hookimpl_type_ignore_comments
branch
from
260fad6
to
c02b7e4
Compare
|
Mind taking another look at this @gusmonod ? I needed to push another commit to address some test flakiness on |
These no longer trigger a warning with the current versions of mypy, pytest, and pluggy. It looks as though these calls have been typed since pluggy 1.2.0, which was released 3 months ago. Signed-off-by: Matt Wozniski <[email protected]>
Previously only builds and tests were run on a schedule, not linting and docs tests, which let the main branch begin failing to lint without us noticing. Signed-off-by: Matt Wozniski <[email protected]>
This fixes test flakiness caused by allocations made by the interpreter's eval loop itself. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
drop_hookimpl_type_ignore_comments
branch
from
c02b7e4
to
e137fa2
Compare
The allocation sizes performed by this test are too low, and so allocations performed by the interpreter itself could wind up being larger and skewing the test output. Allocate more memory to drown out the noise. Signed-off-by: Matt Wozniski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These no longer trigger a warning with the current versions of mypy,
pytest, and pluggy. It looks as though these calls have been typed since
pluggy 1.2.0, which was released 3 months ago.
We didn't notice this because our lint checks weren't scheduled to run on a schedule. This PR fixes that as well.