Drop # type: ignore comments for @hookimpl

.github/workflows/build.yml

@@ -5,6 +5,9 @@ on:
   pull_request:
     branches:
       - main
+  schedule:
+    # At 12:00 UTC on every day-of-month
+    - cron: "0 12 */1 * *"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

.github/workflows/build_dist.yml

@@ -7,7 +7,7 @@ on:
     types:
       - published
   schedule:
-    # At 12:00 on every day-of-month
+    # At 12:00 UTC on every day-of-month
     - cron: "0 12 */1 * *"
 
 concurrency:

src/pytest_memray/plugin.py

@@ -133,15 +133,15 @@ def __init__(self, config: Config) -> None:
         self.result_metadata_path = self.result_path / "metadata"
         self.result_metadata_path.mkdir(exist_ok=True, parents=True)
 
-    @hookimpl(hookwrapper=True)  # type: ignore[misc] # Untyped decorator
+    @hookimpl(hookwrapper=True)
     def pytest_unconfigure(self, config: Config) -> Generator[None, None, None]:
         yield
         if self._tmp_dir is not None:
             self._tmp_dir.cleanup()
         if os.environ.get("MEMRAY_RESULT_PATH"):
             del os.environ["MEMRAY_RESULT_PATH"]
 
-    @hookimpl(hookwrapper=True)  # type: ignore[misc] # Untyped decorator
+    @hookimpl(hookwrapper=True)
     def pytest_pyfunc_call(self, pyfuncitem: Function) -> object | None:
         func = pyfuncitem.obj
 
@@ -212,7 +212,7 @@ def wrapper(*args: Any, **kwargs: Any) -> object | None:
         pyfuncitem.obj = wrapper
         yield
 
-    @hookimpl(hookwrapper=True)  # type: ignore[misc] # Untyped decorator
+    @hookimpl(hookwrapper=True)
     def pytest_runtest_makereport(
         self, item: Item, call: CallInfo[None]
     ) -> Generator[None, TestReport | None, TestReport | None]:
@@ -245,7 +245,7 @@ def pytest_runtest_makereport(
                 outcome.force_result(report)
         return None
 
-    @hookimpl(hookwrapper=True, trylast=True)  # type: ignore[misc] # Untyped decorator
+    @hookimpl(hookwrapper=True, trylast=True)
     def pytest_report_teststatus(
         self, report: CollectReport | TestReport
     ) -> Generator[None, TestReport, None]:
@@ -257,7 +257,7 @@ def pytest_report_teststatus(
             outcome.force_result(("failed", "M", "MEMORY PROBLEMS"))
         return None
 
-    @hookimpl  # type: ignore[misc] # Untyped decorator
+    @hookimpl
     def pytest_terminal_summary(
         self, terminalreporter: TerminalReporter, exitstatus: ExitCode
     ) -> None:

tests/test_pytest_memray.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import re
 import xml.etree.ElementTree as ET
 from types import SimpleNamespace
 from unittest.mock import ANY
@@ -10,6 +11,25 @@
 from pytest import ExitCode
 from pytest import Pytester
 
+from pytest_memray.marks import StackFrame
+
+
+def extract_stacks(test_output: str) -> list[list[StackFrame]]:
+    ret: list[list[StackFrame]] = []
+    before_start = True
+    for line in test_output.splitlines():
+        if before_start:
+            if "List of allocations:" in line:
+                before_start = False
+        elif "allocated here" in line:
+            ret.append([])
+        elif (match := re.match(r"^ {8}([^:]+):(.*):(\d+)$", line)) is not None:
+            ret[-1].append(
+                StackFrame(function=match[1], filename=match[2], lineno=int(match[3]))
+            )
+
+    return ret
+
 
 def test_help_message(pytester: Pytester) -> None:
     result = pytester.runpytest("--help")
@@ -176,10 +196,11 @@ def test_foo():
 
     assert result.ret == ExitCode.TESTS_FAILED
 
-    output = result.stdout.str()
-
-    assert "valloc:" in output
-    assert output.count("rec:") == min(num_stacks - 1, 10)
+    stacks = extract_stacks(result.stdout.str())
+    valloc_stacks = [stack for stack in stacks if stack[0].function == "valloc"]
+    (valloc_stack,) = valloc_stacks
+    num_rec_frames = sum(1 for frame in valloc_stack if frame.function == "rec")
+    assert num_rec_frames == min(num_stacks - 1, 10)
 
 
 @pytest.mark.parametrize("native", [True, False])
@@ -348,11 +369,11 @@ def test_memray_report_limit(pytester: Pytester) -> None:
         allocator = MemoryAllocator()
 
         def allocating_func1():
-            allocator.valloc(1024)
+            allocator.valloc(1024*1024)
             allocator.free()
 
         def allocating_func2():
-            allocator.valloc(1024*2)
+            allocator.valloc(1024*1024*2)
             allocator.free()
 
         def test_foo():