Add fast path for parseInt and parseFloat
#4542
Merged
+109
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
HalidOdat
force-pushed
the
optimization/parse-int-float-fast-path
branch
3 times, most recently
from
4573422 to
29f0d5a
Compare
HalidOdat
force-pushed
the
optimization/parse-int-float-fast-path
branch
from
29f0d5a to
c4c3998
Compare
nekevss
reviewed
Dec 2, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
This is looking really good!
I had one issue of sorts that leans more towards a nitpick than anything else.
HalidOdat
force-pushed
the
optimization/parse-int-float-fast-path
branch
from
c4c3998 to
d355e47
Compare
nekevss
approved these changes
Dec 4, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
LGTM.
Had one thought about adding a potential comment. I'll leave that up to you on whether to add it or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.