5 remove products - #261
Conversation
WalkthroughThe PR removes Ukrposhta as a delivery partner from UI components and translations across all supported languages, renames "Chevron" to "Patch" terminology throughout the system, adds two new fabric prints (foxes and leafs_on_blue), removes four product entries, and introduces SENTRY_AUTH_TOKEN to the deployment workflow. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The changes involve multiple file types with a cohesive theme (Ukrposhta removal, Chevron→Patch rename) but are distributed across numerous localization files with repetitive patterns. Several API modifications affect exported products and metadata entries, requiring verification of downstream dependencies. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/data/data/products.ts (2)
510-601: Remove dead code for discontinued products.The functions
smallToolSeatbagandtacticalStembagare defined but not included in theProductsarray or export list. Since these products are being removed per the PR objectives, these function definitions should be deleted entirely to avoid confusion and maintain code cleanliness.Apply this diff to remove the dead code:
-const smallToolSeatbag = () => ({ - id: 'small-tool-seatbag', - name: 'SmallToolSeatbag', - volume: '0.8', - size: `21 x 5-7 x 11`, - weight: null, - material: null, - description: { - short: null, - main: 'SmallToolSeatbagDescription', - conclusion: 'SmallToolSeatbagConclusion', - }, - gallery: 4, - price: { - cordura: { UAH: 1250, EUR: 35 }, - xpac: { UAH: 1550, EUR: 44 }, - }, - fabrics: [{ fabric: Cordura }, { fabric: Xpac }], - embedVideo: null, - category: BICYCLE_EQUIPMENT, - subcategory: SUBCATEGORIES_BICYCLE_EQUIPMENT.SeatBags, - productKit: null, - createdAt: '2022-10-13', -}); - -const barrelBagMini = () => ({-const tacticalStembag = () => ({ - id: 'tactical-stembag', - name: 'TacticalStembag', - volume: '1.0', - size: '22 x 9 x 10', - weight: [ - { - fabric: 'Cordura', - weight: 170, - }, - { - fabric: 'Xpac', - weight: 120, - }, - ], - material: null, - description: { - short: null, - main: 'TacticalStembagDescription', - conclusion: 'TacticalStembagConclusion', - }, - price: { - cordura: { UAH: 1400, EUR: 40 }, - xpac: { UAH: 1600, EUR: 45 }, - }, - gallery: 6, - fabrics: [{ fabric: Cordura }, { fabric: Xpac }], - embedVideo: null, - category: BICYCLE_EQUIPMENT, - subcategory: SUBCATEGORIES_BICYCLE_EQUIPMENT.HandlebarBags, - productKit: null, - createdAt: '2023-07-04', -}); - -const loopHandlebarBag = () => ({
762-788: Fix inconsistent product state.The
hamsterCorduraNavyBlueFoxesfunction is exported (line 1198) but not included in theProductsarray. This creates an inconsistency where the product is exposed in the module's public API but won't appear in the application's product list.Resolution: Based on the PR objective to remove products, this export should be removed. If the product should remain available, add it to the
Productsarray.Apply this diff to remove the inconsistent export:
// hamsterXpacWithoutPockets, - hamsterCorduraNavyBlueFoxes, hamsterCorduraBlackEmbroidery,Also applies to: 1198-1198
🧹 Nitpick comments (1)
.github/workflows/deploy.yaml (1)
15-15: Consider separating unrelated changes into distinct PRs.The addition of
SENTRY_AUTH_TOKENis functionally correct, but it's unrelated to the PR's stated objectives (removing products and updating delivery information). For better change tracking and easier rollback if needed, consider moving infrastructure/tooling updates like this into a separate PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
package-lock.jsonis excluded by!**/package-lock.jsonpublic/img/prints/foxes_100x100@3x.pngis excluded by!**/*.pngpublic/img/prints/foxes_385x355@3x.pngis excluded by!**/*.pngpublic/img/prints/leafs_on_blue_100x100@3x.pngis excluded by!**/*.pngpublic/img/prints/leafs_on_blue_385x355@3x.pngis excluded by!**/*.pngpublic/products/seat-bag-3l/seat-bag-3l_5_115x120@3x.pngis excluded by!**/*.pngpublic/products/seat-bag-3l/seat-bag-3l_5_460x580@3x.pngis excluded by!**/*.png
📒 Files selected for processing (12)
.github/workflows/deploy.yaml(1 hunks)src/components/deliveryPaymentPage/deliveryAndPayment/DeliveryAndPayment.tsx(1 hunks)src/data/data/fabrics/fabricsData.js(1 hunks)src/data/data/products.ts(1 hunks)src/i18n/en/common/enCommon.js(2 hunks)src/i18n/pl/common/plCommon.js(1 hunks)src/i18n/server/en/deliveryAndPayment/enDeliveryAndPayment.ts(1 hunks)src/i18n/server/meta/metaData.js(8 hunks)src/i18n/server/pl/deliveryAndPayment/plDeliveryAndPayment.ts(1 hunks)src/i18n/server/products/productsData.js(5 hunks)src/i18n/server/uk/deliveryAndPayment/ukDeliveryAndPayment.ts(1 hunks)src/i18n/uk/common/ukCommon.js(2 hunks)
🔇 Additional comments (13)
src/i18n/pl/common/plCommon.js (1)
192-192: LGTM! Delivery text updated consistently.The removal of Ukrposhta from the international delivery options is consistent with the broader changes across all language files in this PR.
src/i18n/server/en/deliveryAndPayment/enDeliveryAndPayment.ts (1)
14-14: LGTM! English delivery text updated consistently.The removal of Ukrposhta reference aligns with the parallel updates in Ukrainian and Polish translations.
src/i18n/server/uk/deliveryAndPayment/ukDeliveryAndPayment.ts (1)
13-13: LGTM! Ukrainian delivery text updated consistently.The update aligns with the corresponding changes in English and Polish translations, maintaining consistency across all supported languages.
src/components/deliveryPaymentPage/deliveryAndPayment/DeliveryAndPayment.tsx (1)
47-47: LGTM! Logo sizing adjusted for visual consistency.The width adjustment from 150 to 115 maintains visual consistency with other delivery partner logos in the UI, especially given the removal of the Ukrposhta International logo block mentioned in the summary.
src/i18n/server/pl/deliveryAndPayment/plDeliveryAndPayment.ts (1)
14-14: LGTM! Polish delivery text updated consistently.This completes the consistent update across all three language translations (UK, EN, PL) for the international delivery partner information.
src/i18n/uk/common/ukCommon.js (1)
238-238: LGTM! UI label updated from Chevrons to Patches.The terminology change aligns with the broader renaming effort across the codebase.
src/data/data/fabrics/fabricsData.js (1)
60-61: Verification complete: Image assets confirmed for both new fabric prints.The image assets for 'foxes' and 'leafs_on_blue' are present in the expected location (
public/img/prints/):
foxes_100x100@3x.pngandfoxes_385x355@3x.pngleafs_on_blue_100x100@3x.pngandleafs_on_blue_385x355@3x.pngTranslations are properly defined in
productsData.js, and all code references are consistent. The changes are ready.src/i18n/en/common/enCommon.js (2)
192-192: LGTM! Delivery partner list updated correctly.The removal of Ukrposhta from the delivery details is clean and consistent with the PR objectives.
224-224: LGTM! Terminology updated consistently.The change from "Chevrons" to "Patches" aligns with the broader terminology shift across the codebase.
src/data/data/products.ts (2)
902-928: Clarify product availability status.The
barrelBagWithEmbroideryYellowfunction is exported (line 1203) but not included in theProductsarray. This might be intentional if it's handled separately as an "in stock" item, but the inconsistency should be clarified.Please verify: Should this product be:
- Added to the
Productsarray (if it should appear in the general product catalog), or- Removed from exports (if it's being discontinued), or
- Left as-is (if there's a separate mechanism for handling in-stock variants)
Also applies to: 1203-1203
183-183: Gallery count change verified as correct.The gallery value reduction from 5 to 4 is intentional and properly documented in commit e8d0bbd ("remove seatbag image"). Current assets contain exactly 4 gallery images for seatBag3L, confirming the corresponding image was removed as expected.
src/i18n/server/products/productsData.js (1)
353-356: LGTM! Translation updates are consistent and complete.The terminology changes from "Chevron/Шеврон" to "Patch/Патч" are properly implemented across all languages (Ukrainian, English, Polish). The addition of new fabric prints (
foxesandleafs_on_blue) is well-structured with complete translations for all three languages.Also applies to: 403-405, 432-511, 892-921
src/i18n/server/meta/metaData.js (1)
365-497: LGTM! Metadata terminology updates are thorough and consistent.All patch-related metadata entries have been properly updated from "Chevron/Шеврон" to "Patch/Патч" across Ukrainian, English, and Polish translations. The descriptions have also been updated to consistently reference the new "patch" terminology.
|
2 participants
removed tactical steam bad and small tool seatbag, updated in stock page
Summary by CodeRabbit
Release Notes
New Features
Changes