ENH: Adds ability to fetch GTDB v220 to get-gtdb-data #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbokulich
requested changes
Jun 5, 2024
There was a problem hiding this comment.
thanks @mikerobeson ! Looks good to me. Ignore my inline comment.
The test failures are unrelated to this PR, so I will merge and we can fix those separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #183.
Also includes a refactor of some code... That is, GTDB v220 now hosts the FASTA files as
fna.gz, while files for the older versions of the database continue to be hosted astar.gz.