TEMPFIX: skip unit tests that rely on q2-longitudinal if it is not installed #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misialq
reviewed
Jun 7, 2024
There was a problem hiding this comment.
While I'm running the tests, something else that occurred to me now: should this PR also disable the action registration in the same case? The current changes only allow skipping the tests but technically an unlucky user could still use the action that relies on q2-longitudinal?
nbokulich
added
the
do-not-merge
|
closing in favor of #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only temporary, until we finish replacing the q2-longitudinal dependency with q2-visard.
We will skip tests that rely on q2-longitudinal if q2-longitudinal is not installed in the environment.