Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporated Cutadapt for primer removal and binning #72

Merged
merged 19 commits into from
Nov 10, 2023

Conversation

lina-kim
Copy link
Collaborator

Closes #51 and #62. Introduces Cutadapt to the workflow for both primer removal and binning. Though it may not be the most computationally efficient method, the workflow takes a single FASTQ input artifact and splits it into N artifacts depending on the N primers provided by the user.

As a result, this removes the former FASTQ split processes. I'm open to further discussion on whether we should bring that back for efficiency's sake.

@lina-kim lina-kim added this to the Beta release 1.0b 🪄 milestone Nov 10, 2023
@lina-kim lina-kim self-assigned this Nov 10, 2023
@lina-kim lina-kim linked an issue Nov 10, 2023 that may be closed by this pull request
@lina-kim
Copy link
Collaborator Author

Merging now. @ChristosMatzoros heads-up these changes are coming; unfortunately the Cutadapt stats will take some wrangling to integrate to MultiQC, so take your time. Currently QIIME 2 only outputs Cutadapt stats as a text-based log file, so we'll have to do some text scraping -- but it's not a priority for now.

If you're curious though, here's a toy example log:
trimmed_stats.log

(These changes should've come in a fork but the branch I originally created for minor changes ballooned, whoops!)

@lina-kim lina-kim merged commit 7ef2728 into main Nov 10, 2023
@lina-kim lina-kim deleted the 62-incorporate-primer-removal-with-cutadapt branch November 10, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate primer removal with cutadapt Incorporate primer-based binning prior to primer removal
1 participant