Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Removed AMRFinderPlusAnnotation type #95

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Jul 23, 2024

solves #94

  • Removed AMRFinderPlusAnnotation. Now there are SampleData[AMRFinderPlusAnnotations] and FeatureData[AMRFinderPlusAnnotations] that both use the same type and dir format.
  • Renamed files in fir format from "mutations" to "all_mutations".

Run it locally

  1. First, clone the repo and checkout the PR branch:
git clone https://github.com/bokulich-lab/q2-amr.git
cd q2-amr
git fetch origin pull/95/head:pr-95
git checkout pr-95
pip install -e .

Download test data:
PR-94.zip

  1. Test it out!
qiime tools import --input-path sample_data --output-path amr_annotations.qza --type "SampleData[AMRFinderPlusAnnotations]"
qiime tools import --input-path feature_data --output-path amr_annotation.qza --type "FeatureData[AMRFinderPlusAnnotations]"
  1. Download test files
    PR-88.zip

  2. Test it out!

qiime amr fetch-amrfinderplus-db --o-amrfinderplus-db amrfinderplus_db.qza --verbose
qiime amr annotate-sample-data-amrfinderplus --i-sequences test_mags.qza --output-dir output_mags --i-amrfinderplus-db amrfinderplus_db.qza --p-plus --p-curated-ident --p-organism "Escherichia" --p-report-all-equal --p-coverage-min 0.4 --p-translation-table "11" --verbose
qiime amr annotate-sample-data-amrfinderplus --i-sequences test_contigs.qza --output-dir output_contigs --i-amrfinderplus-db amrfinderplus_db.qza --p-plus --p-curated-ident --p-organism "Escherichia" --p-report-all-equal --p-coverage-min 0.4 --p-translation-table "11" --verbose

@VinzentRisch VinzentRisch requested review from a team and ChristosMatzoros and removed request for a team July 23, 2024 09:37
@ChristosMatzoros
Copy link
Contributor

ChristosMatzoros commented Jul 25, 2024

Hey @VinzentRisch,

Are the changes in annotate_sample_data_amrfinderplus part of this PR? If yes can you give me the commands to test it?

@VinzentRisch
Copy link
Collaborator Author

Yes they belong there. Although a bit hacky that they are there but didn't want a whole other PR for 3 name changes.
I added a second folder and second sets of commands to test sample data annotate function.
Thanks!

Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch,

It passed all the tests, it works as expecrted and the code looks good. Thanks for the extra commands.

@VinzentRisch VinzentRisch merged commit b661340 into bokulich-lab:main Jul 25, 2024
2 checks passed
VinzentRisch added a commit to VinzentRisch/q2-amr that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants