Skip to content

Upgrade Squad.Agents.AI Copilot SDK and MAF bridge - #1560

Closed
tamirdresher wants to merge 1 commit into
bradygaster:devfrom
tamirdresher:squad/aspire-maf-copilot-sdk-upgrade
Closed

Upgrade Squad.Agents.AI Copilot SDK and MAF bridge#1560
tamirdresher wants to merge 1 commit into
bradygaster:devfrom
tamirdresher:squad/aspire-maf-copilot-sdk-upgrade

Conversation

@tamirdresher

@tamirdresher tamirdresher commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • upgrade Microsoft.Agents.AI.GitHub.Copilot from 1.14.0-rc1 to 1.15.0-rc1
  • keep GitHub.Copilot.SDK pinned at 1.0.8
  • apply _MicrosoftAgentsAICopilotSdkVersion to the package project too so every build path resolves the same Copilot SDK / CLI payload

Why

PR #1449 previously tried to bump GitHub.Copilot.SDK from 1.0.3 to 1.0.5, but the build broke when the Copilot client packaging changed and the MAF bridge still resolved the stale SDK floor.

This retry is now unblocked because Squad.Agents.AI already has the explicit SDK bridge/override pattern from the later fix, and moving the MAF adapter forward to 1.15.0-rc1 still works as long as that override is applied consistently.

Decision inbox reference: .squad/decisions/inbox/geordi-maf-sdk-upgrade-unblocked.md

Validation

  • dotnet test Squad.Agents.AI.slnx -c Release
  • packed local nupkg + ran scripts/verify-squad-agents-ai-consumer.ps1
    • verified a real PackageReference consumer gets Copilot CLI 1.0.73
    • confirmed no fallback to stale CLI 1.0.67
  • sample smoke test:
    • dotnet run --project src/Squad.Agents.AI/samples/Squad.Agents.AI.Sample/Squad.Agents.AI.Sample.csproj -c Release --no-build -- --flow=1
    • sample booted, created the agent, and reached the first SDK call successfully

Target repo

Confirmed from git remote -v, gh repo view, and existing PR history that the correct upstream target is bradygaster/squad against dev.

Copilot AI review requested due to automatic review settings July 29, 2026 08:58
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 6121df3

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status Check Details
Single commit 1 commit — clean history
Not in draft Ready for review
Branch up to date Up to date with dev
Copilot review No Copilot review yet — it may still be processing
Changeset present No source files changed — changeset not required
Scope clean No .squad/ or docs/proposals/ files
No merge conflicts No merge conflicts
Copilot threads resolved 0 active Copilot thread(s) resolved (1 outdated skipped)
CI passing 3 check(s) still running

Files Changed (2 files, +21 −19)

File +/−
Directory.Build.props +13 −12
src/Squad.Agents.AI/Squad.Agents.AI.csproj +8 −7

Total: +21 −19


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

🟢 Impact Analysis — PR #1560

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 2
Files added 0
Files modified 2
Files deleted 0
Modules touched 1

🎯 Risk Factors

  • 2 files changed (≤5 → LOW)
  • 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

root (2 files)
  • Directory.Build.props
  • src/Squad.Agents.AI/Squad.Agents.AI.csproj

This report is generated automatically for every PR. See #733 for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Squad.Agents.AI .NET package’s Microsoft Agent Framework Copilot adapter dependency, pins GitHub.Copilot.SDK via a single repo-wide property, and adds both build-time and CI-time guards to ensure the correct Copilot CLI/native payload propagates to transitive consumers (including real external NuGet consumers).

Changes:

  • Bump Microsoft.Agents.AI.GitHub.Copilot to 1.15.0-rc1 and make GitHub.Copilot.SDK version come from $(SquadCopilotSdkVersion).
  • Add a pack-time generated buildTransitive/Squad.Agents.AI.props bridge to force _MicrosoftAgentsAICopilotSdkVersion for external consumers.
  • Add a hermetic consumer verification PowerShell script and CI steps to detect stale/mismatched Copilot CLI payload downloads.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Squad.Agents.AI/Squad.Agents.AI.csproj Updates dependency versions and generates a pack-time buildTransitive props bridge to keep Copilot SDK/CLI resolution consistent for consumers.
src/Squad.Agents.AI/README.md Updates package description to reflect multi-targeting and preview status wording.
scripts/verify-squad-agents-ai-consumer.ps1 Adds a hermetic external-consumer packaging verification script to ensure native Copilot payload propagates correctly.
Directory.Build.props Introduces repo-wide SquadCopilotSdkVersion and forces _MicrosoftAgentsAICopilotSdkVersion to keep adapter bridge imports aligned.
.github/workflows/squad-agents-ai-ci.yml Extends CI to resolve the expected CLI version dynamically and runs regression/consumer packaging checks.

Comment on lines +117 to +121
$nupkgsFull = (Resolve-Path $NupkgsDir).Path
$candidateNupkgs = @(Get-ChildItem -Path $nupkgsFull -Filter "squad.agents.ai.*.nupkg")
if ($candidateNupkgs.Count -eq 0) {
throw "No 'squad.agents.ai.*.nupkg' found in '$nupkgsFull'. Did the Pack step run before this check?"
}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tamirdresher
tamirdresher force-pushed the squad/aspire-maf-copilot-sdk-upgrade branch from 1af93a6 to 6121df3 Compare July 29, 2026 09:03
bradygaster added a commit that referenced this pull request Aug 4, 2026
Upgrade Squad.Agents.AI Copilot SDK (rebased from #1560)

Copy link
Copy Markdown
Owner

Superseded by #1602 which cherry-picks this PR's meaningful changes (Directory.Build.props condition removal + comment updates) onto current dev. The .csproj version bumps were already superseded by dependabot updates on dev (1.16.0, Extensions 10.8.3/10.0.10). Thank you @tamirdresher!

@bradygaster bradygaster closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants