Upgrade Squad.Agents.AI Copilot SDK and MAF bridge - #1560
Conversation
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (1 outdated skipped) |
| ❌ | CI passing | 3 check(s) still running |
Files Changed (2 files, +21 −19)
| File | +/− |
|---|---|
Directory.Build.props |
+13 −12 |
src/Squad.Agents.AI/Squad.Agents.AI.csproj |
+8 −7 |
Total: +21 −19
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🟢 Impact Analysis — PR #1560Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (2 files)
This report is generated automatically for every PR. See #733 for details. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Squad.Agents.AI .NET package’s Microsoft Agent Framework Copilot adapter dependency, pins GitHub.Copilot.SDK via a single repo-wide property, and adds both build-time and CI-time guards to ensure the correct Copilot CLI/native payload propagates to transitive consumers (including real external NuGet consumers).
Changes:
- Bump
Microsoft.Agents.AI.GitHub.Copilotto1.15.0-rc1and makeGitHub.Copilot.SDKversion come from$(SquadCopilotSdkVersion). - Add a pack-time generated
buildTransitive/Squad.Agents.AI.propsbridge to force_MicrosoftAgentsAICopilotSdkVersionfor external consumers. - Add a hermetic consumer verification PowerShell script and CI steps to detect stale/mismatched Copilot CLI payload downloads.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Squad.Agents.AI/Squad.Agents.AI.csproj | Updates dependency versions and generates a pack-time buildTransitive props bridge to keep Copilot SDK/CLI resolution consistent for consumers. |
| src/Squad.Agents.AI/README.md | Updates package description to reflect multi-targeting and preview status wording. |
| scripts/verify-squad-agents-ai-consumer.ps1 | Adds a hermetic external-consumer packaging verification script to ensure native Copilot payload propagates correctly. |
| Directory.Build.props | Introduces repo-wide SquadCopilotSdkVersion and forces _MicrosoftAgentsAICopilotSdkVersion to keep adapter bridge imports aligned. |
| .github/workflows/squad-agents-ai-ci.yml | Extends CI to resolve the expected CLI version dynamically and runs regression/consumer packaging checks. |
| $nupkgsFull = (Resolve-Path $NupkgsDir).Path | ||
| $candidateNupkgs = @(Get-ChildItem -Path $nupkgsFull -Filter "squad.agents.ai.*.nupkg") | ||
| if ($candidateNupkgs.Count -eq 0) { | ||
| throw "No 'squad.agents.ai.*.nupkg' found in '$nupkgsFull'. Did the Pack step run before this check?" | ||
| } |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1af93a6 to
6121df3
Compare
Upgrade Squad.Agents.AI Copilot SDK (rebased from #1560)
|
Superseded by #1602 which cherry-picks this PR's meaningful changes (Directory.Build.props condition removal + comment updates) onto current dev. The .csproj version bumps were already superseded by dependabot updates on dev (1.16.0, Extensions 10.8.3/10.0.10). Thank you @tamirdresher! |
Summary
Microsoft.Agents.AI.GitHub.Copilotfrom1.14.0-rc1to1.15.0-rc1GitHub.Copilot.SDKpinned at1.0.8_MicrosoftAgentsAICopilotSdkVersionto the package project too so every build path resolves the same Copilot SDK / CLI payloadWhy
PR #1449 previously tried to bump
GitHub.Copilot.SDKfrom1.0.3to1.0.5, but the build broke when the Copilot client packaging changed and the MAF bridge still resolved the stale SDK floor.This retry is now unblocked because
Squad.Agents.AIalready has the explicit SDK bridge/override pattern from the later fix, and moving the MAF adapter forward to1.15.0-rc1still works as long as that override is applied consistently.Decision inbox reference:
.squad/decisions/inbox/geordi-maf-sdk-upgrade-unblocked.mdValidation
dotnet test Squad.Agents.AI.slnx -c Releasescripts/verify-squad-agents-ai-consumer.ps11.0.731.0.67dotnet run --project src/Squad.Agents.AI/samples/Squad.Agents.AI.Sample/Squad.Agents.AI.Sample.csproj -c Release --no-build -- --flow=1Target repo
Confirmed from
git remote -v,gh repo view, and existing PR history that the correct upstream target isbradygaster/squadagainstdev.