Upgrade Squad.Agents.AI Copilot SDK (rebased from #1560) - #1602
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🟢 Impact Analysis — PR #1602Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (2 files)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ❌ | Copilot threads resolved | 2 unresolved Copilot thread(s) — fix and resolve before merging |
| ✅ | CI passing | All checks passing |
Files Changed (2 files, +14 −13)
| File | +/− |
|---|---|
Directory.Build.props |
+13 −12 |
src/Squad.Agents.AI/Squad.Agents.AI.csproj |
+1 −1 |
Total: +14 −13
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
Pull request overview
This PR updates the repo-wide MSBuild override that pins _MicrosoftAgentsAICopilotSdkVersion so it applies universally (including the Squad.Agents.AI package project), aiming to prevent the MAF buildTransitive bridge from importing stale Copilot SDK targets. It also includes a small comment update in the Squad.Agents.AI project file.
Changes:
- Apply
_MicrosoftAgentsAICopilotSdkVersion=$(SquadCopilotSdkVersion)unconditionally inDirectory.Build.props(removing theMSBuildProjectNameexclusion). - Update the prerelease rationale comment in
Squad.Agents.AI.csproj(but it currently mismatches the actual dependency version).
Show a summary per file
| File | Description |
|---|---|
Directory.Build.props |
Makes _MicrosoftAgentsAICopilotSdkVersion apply to all projects to avoid buildTransitive fallback to a stale SDK floor. |
src/Squad.Agents.AI/Squad.Agents.AI.csproj |
Updates a prerelease rationale comment (needs alignment with the now-stable MAF package reference). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
| <!-- | ||
| Prerelease because Microsoft.Agents.AI.GitHub.Copilot 1.14.0-rc1 (below) is itself a | ||
| Prerelease because Microsoft.Agents.AI.GitHub.Copilot 1.15.0-rc1 (below) is itself a | ||
| prerelease package. A STABLE Squad.Agents.AI depending on a prerelease package makes | ||
| `dotnet pack` emit NU5104 ("A stable release ... should not have a prerelease | ||
| dependency"). Prior releases (0.2.0 through 0.5.5) stayed stable and carried that |
There was a problem hiding this comment.
@copilot Fix the code for this review comment.
When a review comment includes a suggested change, apply the suggestion exactly.
Do not make changes beyond what is described in the linked review comment.
| version the adapter itself was packed against, its nuspec's dependency FLOOR | ||
| (1.0.5 for Microsoft.Agents.AI.GitHub.Copilot 1.14.0-rc1), NOT the version this repo | ||
| actually depends on ($(SquadCopilotSdkVersion), i.e. 1.0.7). Left unset, any project | ||
| (still 1.0.5 in Microsoft.Agents.AI.GitHub.Copilot 1.15.0-rc1), NOT the version this repo |
There was a problem hiding this comment.
@copilot Fix the code for this review comment.
When a review comment includes a suggested change, apply the suggestion exactly.
Do not make changes beyond what is described in the linked review comment.
Cherry-pick of PR #1560 by @tamirdresher, rebased onto current dev.
The package version bumps (.csproj) were superseded by subsequent dependabot updates on dev (1.16.0, Extensions 10.0.10/10.8.3), so this PR carries only the meaningful changes:
Original PR: #1560
Supersedes #1560
Co-authored-by: Tamir Dresher tamird@microsoft.com