make check_training_data_exists more strict, and test it #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR
What does this PR do?
Makes
check_training_data_existsmore strict, by requiring both non-empty training data layers to return True.Also adds tests and docstring for this function.
References
Closes #527
How has this PR been tested?
I have run new tests locally without the
xfailand they pass, only after the changes made here to the source code, but not before.Is this a breaking change?
Yes - users can't get away with one empty or non-existent training data layer anymore.
Does this PR require an update to the documentation?
Our tutorial still works the same, so no change needed there. This change enforces good practice with users.
Have added a docstring to a function that didn't have one.
Checklist: