Update patches from Chromium 76.0.3809.132 to Chromium 77.0.3865.75 (uplift to 0.68.x)#3385
Merged
Update patches from Chromium 76.0.3809.132 to Chromium 77.0.3865.75 (uplift to 0.68.x)#3385
Conversation
Brave syncer (uplift to 0.69.x)
bsclifton
force-pushed
the
c77_0.68.x
branch
from
ae4244e to
4d9676d
Compare
4 tasks
bsclifton
force-pushed
the
c77_0.68.x
branch
3 times, most recently
from
12e75e7 to
ec3481b
Compare
Network Service 0.69.x
Update patches from Chromium 76.0.3809.132 to Chromium 77.0.3865.65
Issue 2351: NetworkService: Untie shield callbacks from net::URLRequest.
Untie more network callbacks from net::URLRequest
bsclifton
force-pushed
the
c77_0.68.x
branch
2 times, most recently
from
21d0b45 to
5afd93e
Compare
Uplift omaha update(prepare 10.0.18362.0 SDK update) to 0.69
bsclifton
force-pushed
the
c77_0.68.x
branch
from
5afd93e to
f304c43
Compare
bsclifton
force-pushed
the
c77_0.68.x
branch
from
21c5ef1 to
dd8cfb1
Compare
Sync: never show service error status in browser UI
Fix brave/brave-browser#5249 The previous method of wvh->SetWebUIProperty has issues in that the rvh does not always fire the 'ready' event, especially when navigating 'back'. Using DataSource is a more consistent chromium method for sending properties to the JS context. However, this is usually used for non-changing data. Whilst an UpdateDataSource function does exist, that kind of data is usually pulled from the JS via an explicit call to the C++ WebUI, so we may have to go down that route. The issue with the implementation in this commit is that a page may miss the 'updated' events that fire, for example due to have being navigated away and then back to the page. SetWebUIProperty was also causing issues with browser tests in guest windows. - Creates JS -> C++ functions to get data for: Preferences, Stats and PrivateProperties (alternativeSearchEngine). loadTimeData is also not a great place for data which can change. Although a DataSource (i.e. strings.js and loadTimeData.data) can be updated, it is complicated and is not normal chromium pattern. Since this data is not required exactly at page creation (since it is not read via static HTML but via React in JS), then we can afford the time it takes to request this data via JS. - Converting to a JS API required refactoring some of the app store / reducer initialization, including creating the concept of 'initial data' which is any data required to render the page. Since we need Preferences to know what to show, and we need Stats since they are shown on the initial page load, then those are contained within. Includes some minor cleanup with regard to 'API' separation and definition. - Fixes storage being loaded multiple times during redux init (the function is called with an empty state param 3 times, so the state was being loaded from storage 3 times). - Only saves to local storage the state which we will be re-used.
…ucer is finished This is an anti-pattern and could introduce bugs. See discussion at https://stackoverflow.com/questions/36730793/can-i-dispatch-an-action-in-reducer
C77 0.68.x ntp api
The feature is not ready yet and whilst a flag exists, we default it to on (unlike Chromium) since we use the backend of the feature as a component for the Brave Ads feature
Reader Mode: remove UI button (0.68.x)
This fixes a regression unintentionally introduced with #3033 where port would not added (but chromium would add port when you block/unblock using omnibox) Fixes brave/brave-browser#5973
Generate symbols using single thread
4 tasks
bsclifton
changed the title
bsclifton
changed the title
kjozwiak
approved these changes
Sep 11, 2019
Member
kjozwiak
left a comment
kjozwiak
left a comment
There was a problem hiding this comment.
Uplift into 0.68.x approved. Please make sure that all the correct labels are being used and all associated issues that are relevant to this PR are moved into the correct milestone.
4 tasks
Contributor
|
Looks like upgrading to Chromium 77.0.3865.75 breaks #795 👀 (see portapps/brave-portable#33) |
Member
Author
|
cc: @mkarolin |
Collaborator
|
The patches and chromium_src overrides from #795 are in place and at least --disable-machine-id gets the override triggered. Haven't checked the encryption flag, but the patch/override are still in place. |
Contributor
|
@mkarolin Just check and |
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Update Nightly channel to: 0.63.0
Contributor
|
@mkarolin @bsclifton Do you have any clue to fix this? I would like to help but there are many changes in this PR. Maybe components-os_crypt-os_crypt_win.cc.patch has to be updated following this commit on chromium? |
|
I have a problem that --disable-encryption-win doesn't work because I'm using a Brave portable. |
Closed
Contributor
|
@mkarolin @bsclifton I've createda PR #4194 to fix this issue if you want to take a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplift of #3358 and #3400
Fixes brave/brave-browser#5375
Fixes brave/brave-browser#5966
Related brave/brave-browser#5943
Approved, please ensure that before merging:
After you merge:
This includes the following uplifts:
And then the following PRs created against this branch: