Fix os_crypt_win patch#4194
Closed
crazy-max wants to merge 1 commit intobrave:masterfrom
crazy-max:master
Closed
Conversation
4 tasks
Collaborator
|
@crazy-max, the chromium commit you mentioned is in Chromium 80 (https://storage.googleapis.com/chromium-find-releases-static/265.html#265b39473af0faac989b44afb6d4eb5cb2fd2e24). Our master is still on Chromium 79 at the moment. |
Contributor
Author
|
@mkarolin My bad.. You can close or hold this PR. |
Collaborator
|
@crazy-max, it's no problem at all. Thank you for the patch, it will be incorporated into the changes we are making for the Chromium 80 upgrade. https://github.com/brave/brave-core/pull/4234/files#diff-486ab95052854b861ce72612cfa804a0 |
Contributor
Author
|
It will at least have been useful ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by #3385. components-os_crypt-os_crypt_win.cc.patch has to be updated following this commit on chromium. See also portapps/brave-portable#33.