Initial config for stylelint #747

ugifractal · 2025-09-19T05:45:00Z

No description provided.

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

* Refactor tailwind.css: Change import statement to use URL and reorganize hover effect styles * Refactor role styles in tailwind.css: Consolidate border and color properties for roles * Fix import statement and clean up whitespace in tailwind.css

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

* Natural language fixes in Markdown files * Update DEVELOPER_HELP.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

…ess#590)

) * Format base.njk with Prettier and run pre-commit hooks * Optimize PNGs via pre-commit (oxipng) * Unchanged package-lock.json and package.json * Removed Cdn * Apply pre-commit autofixes (EOF newline, oxipng) * Update frontend/_includes/layouts/base.njk --------- Co-authored-by: John Bampton <[email protected]>

* Create .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update .deepsource.toml

* Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Validate codecov.yml file with curl * Fix up

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

…cialchess#712)

)

gemini-code-assist

Code Review

This pull request introduces Stylelint to the project for CSS linting, which is a great step for maintaining code quality. I've found a few issues with the initial configuration. There's a syntax error in stylelint.config.js that will prevent it from working. Additionally, the configuration isn't set up to handle Tailwind CSS syntax, and the .stylelintignore file incorrectly ignores a source CSS file while not ignoring a generated one. My review includes suggestions to fix these issues to ensure Stylelint is configured correctly and effectively from the start.

gemini-code-assist · 2025-09-19T05:46:37Z

stylelint.config.js

+export default {
+  extends: ["stylelint-config-standard"],
+};


This configuration has a syntax error and is incomplete for your project.

Syntax Error: There's a trailing semicolon on line 4, which is invalid JavaScript syntax and will cause Stylelint to fail.

Missing Tailwind CSS support: The project uses Tailwind CSS, but stylelint-config-standard doesn't understand Tailwind-specific at-rules like @theme. This will lead to linting errors in frontend/assets/tailwind.css.

I suggest fixing the syntax and adding stylelint-config-tailwindcss. You'll need to install it first: npm i -D stylelint-config-tailwindcss.

Suggested change

export default {

extends: ["stylelint-config-standard"],

};

export default {

extends: ["stylelint-config-standard", "stylelint-config-tailwindcss"],

};

gemini-code-assist · 2025-09-19T05:46:37Z

.stylelintignore

+bundle.css
+tailwind.css
+./_site/assets
+./_deploy/assets


This ignore file has a couple of issues:

tailwind.css is ignored. This seems to be the main source file for your Tailwind CSS (frontend/assets/tailwind.css), which contains custom CSS and should be linted. It's likely being ignored to prevent errors from Tailwind's custom at-rules, but the better solution is to configure Stylelint to understand them (as suggested for stylelint.config.js).

The generated CSS file frontend/assets/styles/base.css is not being ignored. Generated files should typically be excluded from linting.

I suggest updating the ignore file to lint your source CSS and ignore the generated output.

bundle.css frontend/assets/styles/base.css ./_site/assets ./_deploy/assets

$ugifractal$

ugifractal and others added 30 commits September 4, 2025 21:17

$@ugifractal$

Use latest ubuntu

7824584

$@ugifractal$

Use target arch

e945335

$@ugifractal$

Increase nvm version

2f06760

Merge branch 'main' into improve-docker-pre-commit

3b5008f

$@ugifractal$

Fix run layers

805ab58

Merge branch 'main' into improve-docker-pre-commit

682dc26

$@ugifractal$

* Fix Dockerfile with separate user

abdd5a6

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

$@ugifractal$

Fix 404 not found page (brisbanesocialchess#578)

42858f4

$@ugifractal$

Remove duplicate npm-ci hook; refactor local hooks (brisbanesocialche…

fd7ef14

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

$@ugifractal$

Update prettierignore and run (brisbanesocialchess#582)

7cd1e44

$@ugifractal$

pre-commit prettier check JS files (brisbanesocialchess#587)

03574fb

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

$@ugifractal$

Add eslint ignore for the Sphinx doc folder (brisbanesocialchess#589)

7719163

$@ugifractal$

Update README.md add Cloudflare Pages status button (brisbanesocialch…

743e0c2

…ess#590)

$@ugifractal$

Update README.md fix read the docs button link (brisbanesocialchess#591)

a8a234b

$@ugifractal$

Update .deepsource.toml (brisbanesocialchess#600)

7cc995b

* Update .deepsource.toml

$@ugifractal$

Fix conflict

fe40d3e

$@ugifractal$

add pipefail

ea48ec0

$@ugifractal$

add version

7a41cc7

$@ugifractal$

add --no-cache

d9db89f

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

4c6ba1c

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

e177dbd

$@ugifractal$

Validate codecov.yml file with curl (brisbanesocialchess#710)

2b46e57

* Validate codecov.yml file with curl * Fix up

$@ugifractal$

Test Docker with GitHub Actions (brisbanesocialchess#711)

6b58c14

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

$@ugifractal$

Update dprint.yml add name key with emoji value and title (brisbaneso…

39080eb

…cialchess#712)

$@ugifractal$

Update codecov.yml set require_changes: false (brisbanesocialchess#714

81e2d86

)

gemini-code-assist bot reviewed Sep 19, 2025

View reviewed changes

$@ugifractal$

Fix newline

0062057

jbampton added the GitHub Sponsors $5 label Sep 19, 2025

jbampton added this to Chess Sep 19, 2025

jbampton self-assigned this Sep 19, 2025

jbampton moved this to In Progress in Chess Sep 19, 2025

jbampton added this to the September milestone Sep 19, 2025

ugifractal added 18 commits September 19, 2025 12:55

$@ugifractal$

Merge branch 'improve-docker-pre-commit' into ci-fixes

e33a9a7

$@ugifractal$

add pinned version to coverage

280f42b

$@ugifractal$

pin coverage

2cdfa38

$@ugifractal$

pin version

fe04173

$@ugifractal$

run stylelint --fix

c8ff95e

$@ugifractal$

coverage to use sha

a78cb73

$@ugifractal$

use sha

6a189b4

$@ugifractal$

use sha

007062d

$@ugifractal$

use sha

f5633e3

$@ugifractal$

permission change

1299248

$@ugifractal$

supress labeler

be570d5

$@ugifractal$

Merge remote-tracking branch 'upstream/main' into ci-fixes

4c59f61

$@ugifractal$

Use incremental fixes

b758e01

$@ugifractal$

Selective linter

d3fcee9

$@ugifractal$

Fix linter

040bf1e

$@ugifractal$

run pre-commit

1188d45

$@ugifractal$

Merge remote-tracking branch 'upstream/main' into fix-style-lint

2ea8554

$@ugifractal$

Merge branch 'ci-fixes' into fix-style-lint

2b88496

github-actions bot added documentation Improvements or additions to documentation ci infra frontend labels Sep 22, 2025

$@ugifractal$

fix duplicate

dfff502

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Initial config for stylelint #747

Initial config for stylelint #747

Uh oh!

$@ugifractal$ ugifractal commented Sep 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 19, 2025

Uh oh!

gemini-code-assist bot Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Initial config for stylelint #747

Are you sure you want to change the base?

Initial config for stylelint #747

Uh oh!

Conversation

ugifractal commented Sep 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

$@ugifractal$ ugifractal commented Sep 19, 2025