-
-
Notifications
You must be signed in to change notification settings - Fork 55
Initial config for stylelint #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ugifractal
wants to merge
58
commits into
brisbanesocialchess:main
Choose a base branch
from
ugifractal:fix-style-lint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
7824584
Use latest ubuntu
ugifractal e945335
Use target arch
ugifractal 2f06760
Increase nvm version
ugifractal 3b5008f
Merge branch 'main' into improve-docker-pre-commit
jbampton 805ab58
Fix run layers
ugifractal 682dc26
Merge branch 'main' into improve-docker-pre-commit
jbampton abdd5a6
* Fix Dockerfile with separate user
Subham-KRLX d00a9a3
Super-Linter CSS errors (#572)
anufdo 42858f4
Fix 404 not found page (#578)
jbampton fd7ef14
Remove duplicate npm-ci hook; refactor local hooks (#580)
jbampton 4580149
Natural language fixes in Markdown files (#581)
jbampton 7cd1e44
Update prettierignore and run (#582)
jbampton 03574fb
pre-commit prettier check JS files (#587)
jbampton 7719163
Add eslint ignore for the Sphinx doc folder (#589)
jbampton 743e0c2
Update README.md add Cloudflare Pages status button (#590)
jbampton a8a234b
Update README.md fix read the docs button link (#591)
jbampton 506484e
Add ribbon.png asset and update base.njk layout (#537)
GauriMalge e3f5240
Create .deepsource.toml (#598)
jbampton 7cc995b
Update .deepsource.toml (#600)
jbampton 131083a
Update .deepsource.toml (#601)
jbampton fe40d3e
Fix conflict
ugifractal ea48ec0
add pipefail
ugifractal 7a41cc7
add version
ugifractal d9db89f
add --no-cache
ugifractal 4c6ba1c
Merge branch 'main' into improve-docker-pre-commit
ugifractal e177dbd
Merge branch 'main' into improve-docker-pre-commit
ugifractal 2b46e57
Validate codecov.yml file with curl (#710)
jbampton 6b58c14
Test Docker with GitHub Actions (#711)
jbampton 39080eb
Update dprint.yml add name key with emoji value and title (#712)
jbampton 81e2d86
Update codecov.yml set `require_changes: false` (#714)
jbampton 0058dee
Update deploy-eleventy-site-on-pr.yml add name to job (#715)
jbampton 62c0827
Configure codecov.yml add range update target (#713)
jbampton ece4ce0
Update `codecov.yml` add `flags` (#716)
jbampton 66e0d03
Attempt to fix codecov PR comments (#718)
jbampton ce735eb
Create `super-linter.yml`: A combination of multiple linters to run a…
jbampton 9ecaac5
merge main into improve-docker-pre-commit
ugifractal 7162a9b
Merge remote-tracking branch 'upstream/main' into improve-docker-pre-…
ugifractal 76c3fb5
Initial config for stylelint
ugifractal 0062057
Fix newline
ugifractal e33a9a7
Merge branch 'improve-docker-pre-commit' into ci-fixes
ugifractal 280f42b
add pinned version to coverage
ugifractal 2cdfa38
pin coverage
ugifractal fe04173
pin version
ugifractal c8ff95e
run stylelint --fix
ugifractal a78cb73
coverage to use sha
ugifractal 6a189b4
use sha
ugifractal 007062d
use sha
ugifractal f5633e3
use sha
ugifractal 1299248
permission change
ugifractal be570d5
supress labeler
ugifractal 4c59f61
Merge remote-tracking branch 'upstream/main' into ci-fixes
ugifractal b758e01
Use incremental fixes
ugifractal d3fcee9
Selective linter
ugifractal 040bf1e
Fix linter
ugifractal 1188d45
run pre-commit
ugifractal 2ea8554
Merge remote-tracking branch 'upstream/main' into fix-style-lint
ugifractal 2b88496
Merge branch 'ci-fixes' into fix-style-lint
ugifractal dfff502
fix duplicate
ugifractal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
bundle.css | ||
tailwind.css | ||
./_site/assets | ||
./_deploy/assets | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ignore file has a couple of issues:
tailwind.css
is ignored. This seems to be the main source file for your Tailwind CSS (frontend/assets/tailwind.css
), which contains custom CSS and should be linted. It's likely being ignored to prevent errors from Tailwind's custom at-rules, but the better solution is to configure Stylelint to understand them (as suggested forstylelint.config.js
).frontend/assets/styles/base.css
is not being ignored. Generated files should typically be excluded from linting.I suggest updating the ignore file to lint your source CSS and ignore the generated output.