Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to a GKE initiated managedcertificate #1340

Merged
merged 2 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/deployctl/subcommands/ingress_production.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def apply_ingress(browser_deployment: str = None, reads_deployment: str = None,
kubectl(["apply", "-f", os.path.join(manifests_directory(), "gnomad.backendconfig.yaml")])
kubectl(["apply", "-f", os.path.join(manifests_directory(), "gnomad.frontendconfig.yaml")])
kubectl(["apply", "-f", os.path.join(manifests_directory(), "gnomad.ingress.yaml")])
kubectl(["apply", "-f", os.path.join(manifests_directory(), "gnomad.managedcertificate.yaml")])


def main(argv: typing.List[str]) -> None:
Expand Down
3 changes: 2 additions & 1 deletion deploy/manifests/ingress/gnomad.ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ metadata:
tier: production
annotations:
kubernetes.io/ingress.global-static-ip-name: gnomad-prod-global-ip
ingress.gcp.kubernetes.io/pre-shared-cert: gnomad-browser-cert
networking.gke.io/managed-certificates: gnomad-prod-certificate
ingress.gcp.kubernetes.io/pre-shared-cert: gnomad-browser-cert # TODO: remove this after new cert is provisioned
networking.gke.io/v1beta1.FrontendConfig: 'gnomad-frontend-config'
spec:
rules:
Expand Down
9 changes: 9 additions & 0 deletions deploy/manifests/ingress/gnomad.managedcertificate.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: networking.gke.io/v1
kind: ManagedCertificate
metadata:
name: gnomad-prod-certificate
labels:
tier: production
spec:
domains:
- gnomad.broadinstitute.org
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
[tool.black]
line-length = 120

[tool.ruff]
line-length = 120

[tool.pylint.basic]
# ds: frequently used name for a variable containing a Hail table
good-names = [
Expand Down