Patch to remove nightly channel requirement for cargo #241
Closed
jlb6740 wants to merge 3 commits intobytecodealliance:mainfrom
Closed
Patch to remove nightly channel requirement for cargo #241jlb6740 wants to merge 3 commits intobytecodealliance:mainfrom
jlb6740 wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
jlb6740
changed the title
fitzgen
approved these changes
Jun 8, 2023
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
LGTM w/ a rebase on top of the ackerman fix
abrown
reviewed
Jun 8, 2023
Member
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
Searching around in the repository for "nightly", I see additional uses in .github/workflows and several other places. I think it would make sense to remove those as well since that way we will (1) avoid confusing users and (2) make sure in CI that +nightly is in fact not needed.
Member
|
I don't think we can actually merge this. Once I removed nightly from CI we get failures related to the precision crate missing something on Windows. |
Merged
Member
|
Superseded by #291. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't remember now what problem prompted the creation of this issue #239 but this patch is to remove the nightly requirement for cargo building and running of benchmarks.