Conversation
|
The windows failure has to do with dropping nightly and some antiquated code paths in the precision crate that, I believe, are assuming that inline assembly for rust isn't available on stable. Since that has been available for some time, I'll probably look to patch (and upstream) changes to precision as the path forward on that. |
|
The most recent commit should not have fixed anything, but it appears that it did or the windows failure is spurious :/ I'm willing to call this ready for review unless others have specific suggestions on Windows -- I don't currently have ready access to a Windows machine to diagnose Windows specific failures. |
|
jedisct1/rust-precision#13 has the upstreaming request for the precision crate. I'm still not sure why the linking issue on windows with the C version arose, but making the suggested change there seemed worthwhile and easier than debugging the linker issue. |
There are build issues on windows that I think should be fixed by this change; pointing to a fork for now as a stop-gap and to test the fix. Hopefully the change is in an upstream release in the future.
bd23b42 to
a06573f
Compare
|
It looks like this update also ends up incorporating the changed proposed in #241 but with a fix for the precision/windows issues. |
From #290 there were some CI failures unrelated to that change; attempting to fix and simplify things a little bit.
I'll add commits if CI fails with additional bits to address.