Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Cassandra visibility persistence manager for NoSQL support #4201

Closed
wants to merge 10 commits into from
Closed

Refactoring Cassandra visibility persistence manager for NoSQL support #4201

wants to merge 10 commits into from

Conversation

longquanzheng
Copy link
Contributor

What changed?

  1. Create NoSQL interface for shard operation
  2. Extract the logic of Cassandra to implement the interface
  3. Replace visibiltyStore with NoSQL plugin db style

Why?
For #3514

How did you test it?
existing tests

Potential risks
Low risks

Release notes
No

Documentation Changes
No

@longquanzheng longquanzheng changed the title Refactoring Cassandra shard persistence manager for NoSQL support Refactoring Cassandra visibility persistence manager for NoSQL support May 16, 2021
@github-actions github-actions bot force-pushed the qlong-nosql-shard branch from d3bd339 to b355cef Compare May 18, 2021 05:18
@longquanzheng longquanzheng mentioned this pull request May 19, 2021
Closed
@github-actions github-actions bot force-pushed the qlong-nosql-shard branch from 4bd7666 to 813ed0d Compare May 25, 2021 17:51
@longquanzheng longquanzheng force-pushed the qlong-nosql-shard branch 2 times, most recently from d455fda to 0ab1108 Compare May 25, 2021 18:32
@github-actions github-actions bot force-pushed the qlong-nosql-shard branch 2 times, most recently from b6230f4 to 26053ec Compare May 25, 2021 22:50
Base automatically changed from qlong-nosql-shard to master May 25, 2021 23:20
@longquanzheng
Copy link
Contributor Author

close in favor of #4223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll will be requested when the pull request is marked ready for review Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie will be requested when the pull request is marked ready for review neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au will be requested when the pull request is marked ready for review davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx will be requested when the pull request is marked ready for review Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng will be requested when the pull request is marked ready for review shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht will be requested when the pull request is marked ready for review jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster will be requested when the pull request is marked ready for review 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 will be requested when the pull request is marked ready for review sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx will be requested when the pull request is marked ready for review dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir will be requested when the pull request is marked ready for review taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender will be requested when the pull request is marked ready for review demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@longquanzheng