Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton of other nosql plugin and add dynamodb package #4220

Merged
merged 9 commits into from
May 27, 2021

Conversation

longquanzheng
Copy link
Contributor

What changed?

  1. Add skeleton of dynamodb plugin
  2. Add NoSQL configure struct

Why?

  1. For dynamodb implementation
  2. For showing open source community of how to add a mongodb plugin

How did you test it?
existing test

Potential risks
No

Release notes
No

Documentation Changes
No

@longquanzheng longquanzheng requested a review from yux0 May 25, 2021 19:01
@longquanzheng longquanzheng changed the title Add skeleton of dynamodb plugin Add skeleton of other nosql plugin and add dynamodb package May 25, 2021
@github-actions github-actions bot force-pushed the qlong-dynamo-skeleton branch 2 times, most recently from f1f351f to 15ef693 Compare May 26, 2021 03:36
@github-actions github-actions bot force-pushed the qlong-dynamo-skeleton branch from 15ef693 to d99eaaa Compare May 26, 2021 21:57
@longquanzheng longquanzheng force-pushed the qlong-dynamo-skeleton branch from d99eaaa to a3275cf Compare May 27, 2021 05:09
@github-actions github-actions bot merged commit 640d378 into master May 27, 2021
@github-actions github-actions bot deleted the qlong-dynamo-skeleton branch May 27, 2021 18:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 30f026d0-6f01-4089-903b-f48be133c590

  • 7 of 22 (31.82%) changed or added relevant lines in 3 files are covered.
  • 16 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.003%) to 59.799%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/client/factory.go 6 10 60.0%
common/config/persistence.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
common/task/fifoTaskScheduler.go 2 85.57%
service/history/execution/mutable_state_builder.go 2 69.82%
service/matching/taskListManager.go 2 74.72%
common/cache/lru.go 3 90.73%
service/history/execution/context.go 6 68.39%
Totals Coverage Status
Change from base Build b15629f5-4249-4bb9-866b-19083dcdf7ea: 0.003%
Covered Lines: 88509
Relevant Lines: 148011

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants