Changes combined.R to use model_read_lib#69
Merged
ddkapan merged 5 commits intocalacademy-research:mainfrom Apr 7, 2022
Merged
Changes combined.R to use model_read_lib#69ddkapan merged 5 commits intocalacademy-research:mainfrom
ddkapan merged 5 commits intocalacademy-research:mainfrom
Conversation
This implements a library for reading ML outputs and also includes point counts, because using the same approach for indexing helps with consistency.
This adds symlinks from the models/input/ directory that point into the output/ directories where those files were generated. Note that this makes a bit of a mess in .gitignore.
This is a bug that did not show itself when this was being called from a test script where species (plural) had been defined locally but revealed itself when combined.R was ported. It is indended that outerIndices specify which species and years to include and that readMl get to know those in case it can use them to make the query more efficient.
With the right tall input CSV, this now means that combined.R can be run for any single species or year. This leaves one TODO for a cleaner way to work around the "reference" data $indices returned by readCombined.
Collaborator
Author
|
I can't figure out how to change the base branch "diff base" to another pull request. The best way to see the changes here is to only look at commits 3e3d533 and later. |
ddkapan
reviewed
Apr 7, 2022
ddkapan
reviewed
Apr 7, 2022
Collaborator
|
Ditto for PR 69, correct?
|
mkclapp
reviewed
Apr 7, 2022
Collaborator
mkclapp
left a comment
mkclapp
left a comment
There was a problem hiding this comment.
OK to merge as is- after merge I will open a new issue re: when and where we use drive_sync and delete/modify that code from this script once consensus is reached about that.
Collaborator
|
Awesome sounds great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It lets you switch the species and year.
This will wait for PR#68 to be merged before it is merged. The only differences between that PR and this one are the ones in combined.R.
Also we'll still want to test on on Mark's official tall CSV.