-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: poc L10n #306
WIP: poc L10n #306
Conversation
What does POC mean? What is the abbreviation of the phrase? Thank you! |
Just to confirm: after the refactoring, we still continue to use arb files, right? Currently, POEditor relies on arb files. |
Proof of concept I meant that I've quickly thrown something together and it isn't finished at all. Just a proof to show that it works. And yes the localization flow will be exactly the same. |
I wonder if the language can be dynamically switched in the menu after this change is applied? |
Oh as I mentioned in the other PR (#318) this is going to work. I just have the commit locally so I'll have to push that one. |
ok ive rebased it onto #318 now the only todo is to fix the 'system default' locale |
Thanks for your hard work! I expect to start testing new changes in 5 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last line break of the arb file has been changed. Later, after the arb file is exported through POEditor, it may be modified back, but the impact is not big and it can be left unresolved.
Restyled by shellharden Restyled by shfmt Restyled by whitespace
FYI I didn't change it it was a formatting rule by @restyled-io |
The language switch of Swiss German and Traditional Chinese cannot be successful. |
- make new storage reactive - add Database Migrator change how the developerMode reacts
Just a poc regarding some discussion in #284
This contains fixes for #303
TODO
resources.dart
or at least restructure it