Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: poc L10n #306

Merged
merged 1 commit into from
Oct 18, 2021
Merged

WIP: poc L10n #306

merged 1 commit into from
Oct 18, 2021

Conversation

Leptopoda
Copy link
Collaborator

@Leptopoda Leptopoda commented Oct 10, 2021

Just a poc regarding some discussion in #284

This contains fixes for #303

TODO

  • remove resources.dart or at least restructure it
  • fix game page (there where some load functions I just commented out for the poc)
  • fix widget test (the test won't do anything rn)
  • merge WIP: Linting and restructure #284 as this branch is based on it

@restyled-io restyled-io bot mentioned this pull request Oct 10, 2021
@calcitem
Copy link
Owner

What does POC mean? What is the abbreviation of the phrase? Thank you!

@calcitem
Copy link
Owner

Just to confirm: after the refactoring, we still continue to use arb files, right?

Currently, POEditor relies on arb files.

@Leptopoda
Copy link
Collaborator Author

What does POC mean? What is the abbreviation of the phrase? Thank you!

Proof of concept

I meant that I've quickly thrown something together and it isn't finished at all. Just a proof to show that it works.

And yes the localization flow will be exactly the same.

@calcitem
Copy link
Owner

I wonder if the language can be dynamically switched in the menu after this change is applied?

@Leptopoda Leptopoda mentioned this pull request Oct 17, 2021
@Leptopoda
Copy link
Collaborator Author

I wonder if the language can be dynamically switched in the menu after this change is applied?

Oh as I mentioned in the other PR (#318) this is going to work. I just have the commit locally so I'll have to push that one.

@Leptopoda
Copy link
Collaborator Author

ok ive rebased it onto #318

now the only todo is to fix the 'system default' locale

@calcitem
Copy link
Owner

Thanks for your hard work! I expect to start testing new changes in 5 hours.

Copy link
Owner

@calcitem calcitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last line break of the arb file has been changed. Later, after the arb file is exported through POEditor, it may be modified back, but the impact is not big and it can be left unresolved.

Restyled by shellharden

Restyled by shfmt

Restyled by whitespace
@Leptopoda
Copy link
Collaborator Author

The last line break of the arb file has been changed. Later, after the arb file is exported through POEditor, it may be modified back, but the impact is not big and it can be left unresolved.

FYI I didn't change it it was a formatting rule by @restyled-io

@Leptopoda Leptopoda merged commit fd4e0f3 into calcitem:dev Oct 18, 2021
@Leptopoda Leptopoda deleted the l10n branch October 18, 2021 11:34
@calcitem
Copy link
Owner

The language switch of Swiss German and Traditional Chinese cannot be successful.

Leptopoda referenced this pull request Oct 18, 2021
- make new storage reactive
- add Database Migrator

change how the developerMode reacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants