Skip to content

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Oct 16, 2025

This is still not bulletproof, but will handle one more case:

  • buildType that are camelCase instead of just "debug" or "release"

Cases that the findBuildOutput still doesn't support:

  • flavor + buildType (e.g. stagingDebug for staging flavor)
  • just buildType when there are flavors (e.g. debug for staging flavor, will produce 2 APKs)

Todo: unit tests

What I tried and failed:

  • getting the latest build file based on mtime but:
    • Gradle may produce 2 APKs from the same build and this is causing issues
    • Gradle may not overwrite the existing APK so we'd pick a stale one

Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rock Ignored Ignored Oct 16, 2025 0:31am

@thymikee thymikee linked an issue Oct 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rock build:android doesn't create cache

1 participant