Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generated kernel.xml axi manager port width to 512 #1074

Merged
merged 5 commits into from
Jul 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backend/xilinx/xml.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ impl Backend for XilinxXmlBackend {
name: axi_name,
mode: "master",
range: "0xFFFFFFFFFFFFFFFF",
data_width: 64,
data_width: 512, //matches actual hardware width
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a comment here explaining why this needs to be 512? Ideally pointing to documentation somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be good? Is there a deeper reason "why" that should be addressed?

Suggested change
data_width: 512, //matches actual hardware width
// Width should match the bus data width of memory modules
// described in hardware, for example see
// https://github.com/cucapra/calyx/blob/c2b12a0fe6b1ee3aaaae0c66e7c4619ee6c82614/src/backend/xilinx/toplevel.rs#L58
data_width: 512,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works!

port_type: "addressable",
base: "0x0",
});
Expand Down