Memories sent fix #1075
Merged
Memories sent fix #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memories_sent is now asserted when all of the x_send_done signals are asserted. Before, each bit corresponded to a different memory being done. This avoids having computations finish when any one of the memories is done.
nathanielnrn
force-pushed
the
memories-sent-fix
branch
from
4661912
to
423ff0c
Compare
12 tasks
rachitnigam
reviewed
Jul 6, 2022
src/backend/xilinx/toplevel.rs
Outdated
| format!("{}_send_done", mem), | ||
| )); | ||
| } | ||
| ifelse.add_seq(v::Sequential::new_nonblk_assign( |
There was a problem hiding this comment.
Do we still need the if memories.len() == 1 stuff? Seems like fold will do the right thing when memories[1..] is empty? We should still probably have an assert!(..) saying that it should have at least one element?
There was a problem hiding this comment.
Think you're right, made the changes
We assume that at least 1 memory is present, assertion is made at top of toplevel function
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memories_sent assignment part of #1072, part of general effort in #1022