Fixed assertion of ap_done #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap_done is now not asserted based on timeouts, rather only on memories_sent being asserted. Avoids confusing behavior where hardware seems to abort without a reason. At some point we may want to revert this to enable timeouts?
12 tasks
|
LGTM! |
Good point. I agree with removing the timeout for now… I wonder if it will ever come back to bite us. If we ever get frustrated by the hardware seeming to run forever, we can revisit this. (But maybe the hardware should somehow report that it has timed out rather than just silently finishing…) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ap_done is now not asserted based on timeouts, rather only on memories_sent
being asserted. Avoids confusing behavior where hardware seems to abort
without a reason.
At some point we may want to revert this to enable
timeouts?
Part of #1072 and #1022