Add ap_idle generation #1101
Merged
Add ap_idle generation #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ap_idle was not generated, which led to some issues running designs through PYNQ.
sampsyo
reviewed
Jul 14, 2022
| @@ -294,8 +306,12 @@ impl AddressSpace { | |||
| } | |||
|
|
|||
| // port writes to internal register logic | |||
| // reads only | |||
| // XXX(nathanielnrn) Why does this need to be seperate from the above write logic? | |||
| // Seems basically the same to me? | |||
There was a problem hiding this comment.
Indeed; maybe this could be factored out into a function? Or maybe it would be too annoying because of the slight differences in flag values…
There was a problem hiding this comment.
Gave this a shot, indeed a bit annoying because of scope issues, the helper function has a bunch of arguments and imo is not much cleaner than how it is currently. I think refactoring this could be a small issue for later? Willing to work on this more though.
There was a problem hiding this comment.
Yeah, totally, makes sense to me! I can imagine how this would imply a broader refactoring that wouldn't be trivial.
This was referenced Jul 14, 2022
|
Just making sure, is this merge-ready in your opinion? @sampsyo or @rachitnigam |
|
Yes, looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ap_idle signal was not generated, which led to some issues when running designs through PYNQ.
This adds generation and associated logic.
Fixes #1078 and is part of broader efforts of #1072