Update documentation: New style PIFOs, RR, and Strict #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanmohan
approved these changes
Aug 7, 2024
csziklai
added a commit
that referenced
this pull request
Aug 8, 2024
This PR closes #2241. It removes peek from all the queues, making `cmd` now a 1-bit signal. Please note that the corresponding update in the documentation `queues.md` is part of #2237. One minor issue is that now that peek is removed, round robin no longer uses the group `restore_hot`, leading to unused group error. Strict still uses `restore_hot` so I can’t delete it, and if you remember gen_strict_or_rr.py is used to make both strict and round robin queues. I’ve gone ahead and turned off wellformedness in the runt file as a temporary solution because I’m not sure what would be best. What remains to be figured out is how many LUTs and cycles the old designs took versus the new. --------- Co-authored-by: Anshuman Mohan <[email protected]> Co-authored-by: Akash Dhiraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress towards #2191 by adding documentation about round robin and strict queues. Additionally, it completes the last checkbox of #2226 by updating the documentation to use the new style of PIFOs. Recently, it also updates the documentation to reflect the removal of peek (#2241). Because of a git mistake carried forward, this PR supersedes #2223.